Partial properties: diagnostics for mismatch between parts #73250
Conversation
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
RikkiGibson
added
New Feature - Partial Properties
and removed
untriaged
RikkiGibson
changed the title
RikkiGibson
force-pushed
the
partial-properties-2
branch
from
b72eec9
to
e2862e2
Compare
RikkiGibson
force-pushed
the
partial-properties-2
branch
from
4e01d6b
to
6718f15
Compare
| @@ -145,7 +145,18 @@ internal sealed override ImmutableArray<string> NotNullWhenFalseMembers | |||
| bool isNullableAnalysisEnabled, | |||
| BindingDiagnosticBag diagnostics) : | |||
| base(containingType, syntax.GetReference(), location, isIterator: false, | |||
| MakeModifiersAndFlags(property, propertyModifiers, isNullableAnalysisEnabled)) | |||
| MakeModifiersAndFlags( | |||
There was a problem hiding this comment.
The goal of this change is to make it so the getter symbol in public virtual T Prop => ... is not treated as introducing any of its own modifiers.
This makes the behavior of APIs like LocalAccessibility more consistent with properties declared using the accessor list syntax public virtual T Prop { get => ... }.
| itemInspector = static obj => obj switch | ||
| { | ||
| null => "<null>", | ||
| string s => $@"""{s}""", |
There was a problem hiding this comment.
This makes it easier to paste baselines in from an AssertEx.Equal failure, since the string values will already be quoted.
I didn't bother to do escaping here, if anything I would like to output a """-string only if the string is detected to contain any characters that need escaping. It's something which can be addressed when we hit it.
There was a problem hiding this comment.
This introduces a problem where every line of a VerifyIL baseline is quoted. I'll have to look at either adjusting that or reverting this change.
src/Compilers/CSharp/Test/Symbol/Symbols/PartialPropertiesTests.cs
Outdated
Show resolved
Hide resolved
src/Compilers/CSharp/Test/Symbol/Symbols/PartialPropertiesTests.cs
Outdated
Show resolved
Hide resolved
src/Compilers/CSharp/Portable/Symbols/Source/SourcePropertySymbol.cs
Outdated
Show resolved
Hide resolved
src/Compilers/CSharp/Test/Symbol/Symbols/PartialPropertiesTests.cs
Outdated
Show resolved
Hide resolved
|
|
||
| [Fact] | ||
| public void TypeDifference_02() | ||
| { |
There was a problem hiding this comment.
Consider a test like this:
private partial int P1 { get; set; }
partial int P1 { private get => 1; private set {} }| public partial string? M2() => ""; | ||
| } | ||
| """; | ||
|
|
There was a problem hiding this comment.
Please test in vs ref readonly with indexer parameters.
src/Compilers/CSharp/Portable/Symbols/Source/SourcePropertySymbolBase.cs
Show resolved
Hide resolved
…erty explicit implementation
| [Fact] | ||
| public void ModifierDifference_Accessibility_ExplicitDefault_01() | ||
| { | ||
| // only one part explicitly specifies the default accessibility |
There was a problem hiding this comment.
Do we have a similar test (default accessibility vs. explicit accessibility) for accessors?
There was a problem hiding this comment.
I think test ModifierDifference_Accessibility_ExplicitDefault_02 is exercising the scenario adequately because it shows that:
- explicitly specifying the default accessibility on an accessor is an error
- a difference in accessor accessibility modifiers between parts is an error
RikkiGibson
merged commit 176000a
into
dotnet:features/partial-properties
Test plan: #73090