Fix need for redundant enter when rename suggestions are not available

[AmadeusW]

Context

In the current AI rename experience, developer needs to hit Enter twice to complete the rename.

Rename is completed only when user pressed enter and there is no popup with suggestions. Before suggestions were acquired automatically, first enter would close the popup and second enter would complete the rename.

When suggestions are acquired automatically, there is no popup but a list of suggestions. First enter "confirms" selection from the list and selects all text in the textbox. Second enter completes the rename. (We are deciding whether this is a good UX or if we'd like to change it).

Problem

The bug was that we required two enters even if the suggestions were hidden. i.e. user opted out from automatic rename suggestions, and we still required the first enter to "confirm"

in the gif, I'm hitting enter twice. first enter selects the content of the text box

Solution

When suggestions are not visible, don't require second enter
in the gif, I'm hitting enter just once

Notes on commit 1

Currently, we keep two enter behavior when suggestions are visible

in the gif, I'm hitting enter twice. first enter selects the content of the text box

Notes on commit 2

I really don't like the double enter behavior, and the fact that the rename text box content gets selected when suggestions arrive. I made changes in commit 2 to address these. With commit 2, the only time user hits enter twice is when the dropdown is visible (Smart Rename is ON, Automatically getting suggestions is OFF)

in the gif, I'm hitting enter once. when suggestions arrive, there is no select-all that'd cause me to overwrite what I typed so far

in the gif, I'm hitting enter twice because dropdown is used (Automatically getting suggestions is OFF). But notice there is no select-all

[AmadeusW]

@Cosifne please review :)

[Cosifne]

Close this as bot will flow the change to main