Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate the CurrentBlockAnalysisData's _reachingWrites when creating an OperationTreeAnalysis. #73244

Closed
wants to merge 2 commits into from
Closed

Populate the CurrentBlockAnalysisData's _reachingWrites when creating an OperationTreeAnalysis. #73244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
842d111
Populate the CurrentBlockAnalysisData's _reachingWrites when creating…
ToddGrun Apr 26, 2024
e2bd051
Compound operations are reads followed by writes
ToddGrun Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 13 additions & 4 deletions ...er/Core/FlowAnalysis/SymbolUsageAnalysis/SymbolUsageAnalysis.OperationTreeAnalysisData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,12 @@ private sealed class OperationTreeAnalysisData : AnalysisData
private readonly Func<IMethodSymbol, BasicBlockAnalysisData> _analyzeLocalFunction;

private OperationTreeAnalysisData(
PooledDictionary<(ISymbol symbol, IOperation operation), bool> symbolsWriteMap,
PooledHashSet<ISymbol> symbolsRead,
PooledHashSet<IMethodSymbol> lambdaOrLocalFunctionsBeingAnalyzed,
Func<IMethodSymbol, BasicBlockAnalysisData> analyzeLocalFunction)
{
_analyzeLocalFunction = analyzeLocalFunction;
SymbolsWriteBuilder = symbolsWriteMap;
SymbolsWriteBuilder = CreateSymbolsWriteMap(ImmutableArray<IParameterSymbol>.Empty);
SymbolsReadBuilder = symbolsRead;
LambdaOrLocalFunctionsBeingAnalyzed = lambdaOrLocalFunctionsBeingAnalyzed;
}
Expand All @@ -42,11 +41,21 @@ private sealed class OperationTreeAnalysisData : AnalysisData
ISymbol owningSymbol,
Func<IMethodSymbol, BasicBlockAnalysisData> analyzeLocalFunction)
{
return new OperationTreeAnalysisData(
symbolsWriteMap: CreateSymbolsWriteMap(owningSymbol.GetParameters()),
var analysisData = new OperationTreeAnalysisData(
symbolsRead: PooledHashSet<ISymbol>.GetInstance(),
lambdaOrLocalFunctionsBeingAnalyzed: PooledHashSet<IMethodSymbol>.GetInstance(),
analyzeLocalFunction);

analysisData.SetAnalysisDataOnEntryBlockStart(owningSymbol.GetParameters());

return analysisData;
}

private void SetAnalysisDataOnEntryBlockStart(ImmutableArray<IParameterSymbol> parameters)
{
UpdateSymbolsWriteMap(SymbolsWriteBuilder, parameters);
foreach (var parameter in parameters)
CurrentBlockAnalysisData.OnWriteReferenceFound(parameter, operation: null, maybeWritten: false);
}

protected override BasicBlockAnalysisData AnalyzeLocalFunctionInvocationCore(IMethodSymbol localFunction, CancellationToken cancellationToken)
Expand Down
4 changes: 2 additions & 2 deletions ...ndExtensions/Compiler/Core/FlowAnalysis/SymbolUsageAnalysis/SymbolUsageAnalysis.Walker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,12 +196,12 @@ private void ProcessPendingWritesForAssignmentTarget(IAssignmentOperation operat
if (write.Kind != OperationKind.FlowCaptureReference)
{
Debug.Assert(symbolOpt != null);
OnWriteReferenceFound(symbolOpt, write, ValueUsageInfo.Write);

if (isUsedCompoundAssignment)
{
OnReadReferenceFound(symbolOpt);
}

OnWriteReferenceFound(symbolOpt, write, ValueUsageInfo.Write);
}
else
{
Expand Down