Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IOperation of byref member initializer #73243

Merged
merged 2 commits into from Apr 30, 2024
Merged

Fix IOperation of byref member initializer #73243

merged 2 commits into from Apr 30, 2024

Conversation

jjonescz
Copy link
Contributor

Fixes #72916.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 26, 2024
@jjonescz jjonescz marked this pull request as ready for review April 26, 2024 12:43
@jjonescz jjonescz requested a review from a team as a code owner April 26, 2024 12:43
@AlekseyTs
Copy link
Contributor

AlekseyTs commented Apr 26, 2024 •
edited by jjonescz

From the issue:

Should check VB behavior as well.

Has this been done? #Resolved

@AlekseyTs
Copy link
Contributor

Done with review pass (commit 1)

@jjonescz
Copy link
Contributor Author

jjonescz commented Apr 29, 2024 •
edited

I forgot to look into VB, thanks. Looks like it does not have the same problem. Added a test.

In reply to: 2079711840

AlekseyTs
AlekseyTs approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 2)

@jjonescz jjonescz merged commit 62c9c49 into dotnet:main Apr 30, 2024
24 checks passed
@jjonescz jjonescz deleted the 72916-RefMemberInitializer branch April 30, 2024 05:48
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 30, 2024
@dotnet-bot dotnet-bot mentioned this pull request May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

Assignees
No one assigned
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.

Unexpected IInvalidOperation for ref returning property as a target of member initializer
3 participants
@jjonescz @AlekseyTs @333fred