Implement analyzer/fixer: remove unnecessary Call keyword from Call statement

[tats-u]

Fixes #71818

Mandatory:

• Implement the same level as RemoveUnnecessaryByVal

Backlog:

• Support FixAll
• Support CodeCleanUp
• Assign a dedicated code style option name

[CyrusNajmabadi]

Not sure if we would take this for Roslyn itself. Seems like a good candidate for a community driven set of vb migration helpers though!

[tats-u]

That doesn't look like good news.
As you may think, its priority may be lower than ByVal removal.
However, the official document doesn't recommend to abuse Call:
https://learn.microsoft.com/en-us/dotnet/visual-basic/language-reference/statements/call-statement#remarks
Therefore I think we can recommend users to remove redundant Calls not only in reference but also in editors.

[CyrusNajmabadi]

@tats-u I'm simply saying these might be better as a package you maintain yourself.

[tats-u]

@CyrusNajmabadi I wouldn't work on this PR anymore if you(r team) had no plan to make such kind of Analyzer/Codefix (Lighten the colors of unnecessary Call keywords) in the original Roslyn, VS, and online rich editors (and possibly VS Code in the future).
I wonder who other than your team can keep such a huge project well maintained and popular.
If your team hasn't decided to this PR has even a little chance to be merged, I'll continue to try to make it pass all the tests in CI.

[CyrusNajmabadi]

I wonder who other than your team

Lots of people maintain nuget packages. :-)

But roslyn isn't a place where every but if functionality goes. This has a coat for us as well. So the benefit needs to be there to justify it.

Given 30+ years working with vb, and only a single person asking for this, it really sounds like this is a feature for you, Rather than something significant for the entire community.

If you're this passionate about producing solutions for your problems, that's great. But that doesn't really translate to us prioritizing it the same way.

[tats-u]

only a single person asking for this, it really sounds like this is a feature for you, Rather than something significant for the entire community.

Note most VB users won't visit this repo (or vblang repo), and has given up for this feature or raising up their voice for new ones, not only new language ones (announced since .NET 5) but also other ones.

Since your team chose to reject this feature and other new VB-dedicated just-nice-to-have ones even in Analyzer, I'll stop improving this code and focus on C# and other repos. I'll treat VB for .NET as like the IE mode and the Trident engine for Edge.

[CyrusNajmabadi]

Sounds good. Take it easy :)