Enable Arcade V3 publishing in PR Validation #73221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
3 tasks
JoeRobich
commented
May 1, 2024
JoeRobich
commented
May 1, 2024
| "Accept" = "application/vnd.github+json"; | ||
| "X-GitHub-Api-Version" = "2022-11-28" | ||
| } | ||
| $buildNumberName = "$(OriginalBuildNumber) - $($pull_request.user.login) - '$($pull_request.title)'" |
There was a problem hiding this comment.
This is a pretty fancy build number. We have to revert it during the Arcade bits and the VS insertions but for most of the build we will show it and we will exit with it being fancy,
There was a problem hiding this comment.
ooh, I like it :), will make it easier to find them
dibarbet
reviewed
May 1, 2024
| "Accept" = "application/vnd.github+json"; | ||
| "X-GitHub-Api-Version" = "2022-11-28" | ||
| } | ||
| $buildNumberName = "$(OriginalBuildNumber) - $($pull_request.user.login) - '$($pull_request.title)'" |
There was a problem hiding this comment.
ooh, I like it :), will make it easier to find them
JoeRobich
commented
May 1, 2024
Comment on lines
+75
to
+84
| - output: artifactsDrop | ||
| displayName: 'OptProf - Publish to Artifact Services - ProfilingInputs' | ||
| condition: succeeded() | ||
| dropServiceURI: 'https://devdiv.artifacts.visualstudio.com' | ||
| buildNumber: 'ProfilingInputs/$(System.TeamProject)/$(Build.Repository.Name)/$(SourceBranchName)/$(OriginalBuildNumber)' | ||
| sourcePath: '$(Build.SourcesDirectory)\artifacts\OptProf\$(BuildConfiguration)\Data' | ||
| toLowerCase: false | ||
| usePat: true | ||
| accessToken: $(_DevDivDropAccessToken) | ||
| retentionDays: 90 |
There was a problem hiding this comment.
So currently our official build doesn't use the artifactsDrop output and uses an ArtifactsDrop task instead. Do we want to move it over to match?
There was a problem hiding this comment.
Hmm, fine with this way if it works
dibarbet
approved these changes
May 2, 2024
…m/dotnet/roslyn into dev/jorobich/pr-val-v3-publishing
jjonescz
reviewed
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to v3 publishing in order to use publish symbol exclusions. Also, sets a more descriptive build number including the PR author and title.
Example of fancy build number:
Test Run: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9523427&view=results (microsoft)
Test Insertion: waiting for it (microsoft)