Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Roslyn protocol types to System.Text.Json serialization #73207

Merged
merged 5 commits into from
May 15, 2024

Merge branch 'main' into lsp_stj

c1fd7b3
Select commit
Failed to load commit list.
Merged

Switch Roslyn protocol types to System.Text.Json serialization #73207

Merge branch 'main' into lsp_stj
c1fd7b3
Select commit
Failed to load commit list.
Build Analysis / Build Analysis succeeded May 15, 2024 in 0s

.NET Result Analysis

Details

Tip

To unconditionally bypass the build analysis check (turn it green), you can use the escape mechanism feature. The completion time may vary, potentially taking several minutes, depending on the build analysis workload at the moment.

Test Failures (3 tests failed)

🔹 [All failing tests from roslyn-integration-CI]

    Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpGoToImplementation.GoToImplementationFromMetadataAsSource [Details] [0.84% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

    Failing Configuration

    Data Driven SubResults
      Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpGoToImplementation.GoToImplementationFromMetadataAsSource(asyncNavigation: True) (VS2022)
      Exception Message
      Assert.Equal() Failure
                ↓ (pos 0)
      Expected: 'IDisposable' implementations - Entire so···
      Actual:   Go To Implementation - Entire solution
                ↑ (pos 0)
      Stack Trace
         at Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpGoToImplementation.<GoToImplementationFromMetadataAsSource>d__5.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpGoToImplementation.cs:line 140
      --- End of stack trace from previous location where exception was thrown ---
         at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
         at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
         at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
      --- End of stack trace from previous location where exception was thrown ---
         at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
         at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      --- End of stack trace from previous location where exception was thrown ---
         at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
         at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpNewDocumentFormatting.CreateLegacyProjectWithFileScopedNamespaces [Details] [1.53% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

    Failing Configuration

    Data Driven SubResults
      Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpNewDocumentFormatting.CreateLegacyProjectWithFileScopedNamespaces (VS2022)
      Exception Message
      Actual and expected values differ. Expected shown in baseline of diff:
      +Submission192.csx(5, 3): error CS1024: Preprocessor directive expected
      

      Expected: True
      Actual: False


      Stack Trace

         at Roslyn.Test.Utilities.AssertEx.EqualOrDiff(String expected, String actual, String message) in /_/src/Compilers/Test/Core/Assert/AssertEx.cs:line 297
      at Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpNewDocumentFormatting.<VerifyNoErrorsAsync>d__6.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpNewDocumentFormatting.cs:line 142
      --- End of stack trace from previous location where exception was thrown ---
      at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      at Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpNewDocumentFormatting.<CreateLegacyProjectWithFileScopedNamespaces>d__1.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpNewDocumentFormatting.cs:line 42
      --- End of stack trace from previous location where exception was thrown ---
      at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
      --- End of stack trace from previous location where exception was thrown ---
      at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      --- End of stack trace from previous location where exception was thrown ---
      at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

    Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpRename.VerifyRenameLinkedDocumentsAsync [Details] [1.53% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

    Failing Configuration

    Data Driven SubResults
      Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpRename.VerifyRenameLinkedDocumentsAsync (VS2022)
      Exception Message
      Actual and expected values differ. Expected shown in baseline of diff:
      

      public class MyClass
      {
      void Method()
      {

      •    MyTestClass$$ x = new MyTestClass&#40;&#41;;
        
      •    Te$$stClass x = new TestClass&#40;&#41;;
        
        }
        }

      Expected: True
      Actual: False


      Stack Trace

         at Roslyn.Test.Utilities.AssertEx.EqualOrDiff(String expected, String actual, String message) in /_/src/Compilers/Test/Core/Assert/AssertEx.cs:line 297
      at Roslyn.VisualStudio.IntegrationTests.InProcess.EditorVerifierInProcess.<TextEqualsAsync>d__6.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/EditorVerifierInProcess.cs:line 75
      --- End of stack trace from previous location where exception was thrown ---
      at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      at Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpRename.<VerifyRenameLinkedDocumentsAsync>d__20.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpRename.cs:line 765
      --- End of stack trace from previous location where exception was thrown ---
      at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
      --- End of stack trace from previous location where exception was thrown ---
      at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      --- End of stack trace from previous location where exception was thrown ---
      at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

Was this helpful? Yes No