Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Semantic Search to work when ServiceHub is disabled #73196

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sharwell
Copy link
Member

  • Fix some design time build warnings
  • Retarget Semantic Search reference assemblies from net8.0 to netstandard2.0
  • Support Semantic Search in devenv.exe
  • Add Semantic Search to the preview features list

Fixes #72617

@sharwell sharwell requested review from a team as code owners April 23, 2024 17:30
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 23, 2024
Copy link
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not limit semantic search to netstandard2.0 when running on ,NET 8. That unnecessarily limits the APIs and language features the user can use.

@sharwell
Copy link
Member Author

sharwell commented Apr 29, 2024

That unnecessarily limits the APIs and language features the user can use.

In theory, yes. In practice, it doesn't seem likely to make a difference. The approach used in this pull request also matches the behavior the compiler expects for interacting with certain other public APIs, e.g. source generator implementations, so this restriction is not without precedent.

The alternative is to generate and ship multiple sets of reference assemblies, adding a significant amount of complexity to the build and making it unpredictable which set of APIs will be usable for any given search.

It seems like this is something we can add later if there is a demonstrated need, particularly considering that this future addition would not remove any APIs being provided by netstandard2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semantic Search: Consider adding support for in-proc query execution
2 participants