Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invocations statically bound in presence of dynamic arguments should have dynamic result if their dynamic binding succeeded in C# 12 #72885

Closed
wants to merge 6 commits into from

Conversation

AlekseyTs
Copy link
Contributor

@AlekseyTs AlekseyTs commented Apr 5, 2024

Fixes #72750.

Corresponding spec update - dotnet/csharplang#8027

Related to #33011, #72906, #72912, #72913, #72914, #72916, #72931.

…have `dynamic` result if their dynamic binding succeeded in C# 12

Fixes dotnet#72750.

Corresponding spec update - dotnet/csharplang#8027
@AlekseyTs AlekseyTs requested a review from a team as a code owner April 5, 2024 11:01
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Apr 5, 2024
@AlekseyTs
Copy link
Contributor Author

@jaredpar, @dotnet/roslyn-compiler Please review

@AlekseyTs
Copy link
Contributor Author

@RikkiGibson. @333fred, @dotnet/roslyn-compiler Please review

@AlekseyTs
Copy link
Contributor Author

@RikkiGibson. @333fred, @dotnet/roslyn-compiler Please review

@RikkiGibson RikkiGibson self-assigned this Apr 8, 2024
bag.HasAnyResolvedErrors())
{
diagnostics.AddRangeAndFree(createTupleDiagnostics);
createTupleDiagnostics = null;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createTupleDiagnostics = null

Add comment the goal is to suppress the duplicate diagnostic

@AlekseyTs
Copy link
Contributor Author

                return new DeconstructionVariable(checkedVariable, node);

Follow up?


Refers to: src/Compilers/CSharp/Portable/Binder/Binder_Deconstruct.cs:836 in 9ce7dd6. [](commit_id = 9ce7dd6, deletion_comment = False)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language changes are breaking real-world use of dynamic
2 participants