New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure the caret is visible after commit #33827
Conversation
c9a082d
to
b01972e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I tried to repro the integration test. It works without the fix; the caret is visible.
- I think we need a unit test to prove the need for the fix.
The integration tests default to legacy completion. You need to patch the following line or set an environment variable to enable async completion for integration tests. The bug reproduces 100% of the time with async completion. roslyn/src/VisualStudio/IntegrationTest/TestUtilities/LegacyCompletionCondition.cs Line 15 in da920a6
The unit test would be inconclusive relative to an integration test. I will file a follow-up item to add a unit test, but the current integration test is a conclusive demonstration of the issue at hang in the context of the Visual Studio product. |
I re-evaluated it with the new completion and found the issue. Sorry for confusion! The fix is good. I am fine to merge it into master with a follow up issue for a unit test. |
Fixes #33822