Fix completion at the start of readonly documents

Fixes #33829
dotnet · Mar 3, 2019 · 85b5f31 · 85b5f31
1 parent 2cab0d7
commit 85b5f31
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/Features/Core/Portable/Completion/CommonCompletionProvider.cs b/src/Features/Core/Portable/Completion/CommonCompletionProvider.cs
@@ -18,7 +18,7 @@ public override bool ShouldTriggerCompletion(SourceText text, int position, Comp
         {
             switch (trigger.Kind)
             {
-                case CompletionTriggerKind.Insertion:
+                case CompletionTriggerKind.Insertion when position > 0:
                     var insertedCharacterPosition = position - 1;
                     return this.IsInsertionTrigger(text, insertedCharacterPosition, options);
 

diff --git a/src/VisualStudio/IntegrationTest/IntegrationTests/VisualBasic/BasicEditAndContinue.cs b/src/VisualStudio/IntegrationTest/IntegrationTests/VisualBasic/BasicEditAndContinue.cs
@@ -198,8 +198,7 @@ public void MultiProjectDebuggingWhereNotAllModulesAreLoaded()
             VisualStudio.ErrorList.Verify.NoErrors();
         }
 
-        // 🐛 This test crashes when async completion is enabled
-        [ConditionalWpfFact(typeof(LegacyCompletionCondition))]
+        [WpfFact]
         [WorkItem(33829, "https://github.com/dotnet/roslyn/issues/33829")]
         public void DocumentStateTrackingReadonlyInRunMode()
         {