Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CA2023: Adds validation against invalid braces in logger message templates) #7286

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

fix(CA2023: Adds validation against invalid braces in logger message templates) #7286

wants to merge 22 commits into from

Commits on Apr 11, 2024

  1. Stabilize package versions (dotnet#7002)

    @ViktorHofer @Kritner
    ViktorHofer authored and Kritner committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    508a65a View commit details
    Browse the repository at this point in the history

  2. Revert "Stabilize package versions (dotnet#7002)" (dotnet#7003) 

    This reverts commit e640355.
    @ViktorHofer @Kritner
    ViktorHofer authored and Kritner committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    dcb58dd View commit details
    Browse the repository at this point in the history

  3. Adds validation against invalid bracket pairs 

    * Fixes dotnet#7285
    @Kritner
    Kritner committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    116b8c4 View commit details
    Browse the repository at this point in the history

  4. Fix extra break flagged by CI

    @Kritner
    Kritner committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    562618c View commit details
    Browse the repository at this point in the history

  5. Remove one branch to be fully covered

    @Kritner
    Kritner committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    9adceb5 View commit details
    Browse the repository at this point in the history

  6. Adds secondary occurrence of CA2017 around mismatched braces

    @Kritner
    Kritner committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    1d8357f View commit details
    Browse the repository at this point in the history

  7. Adds new messages to base resource file

    @Kritner
    Kritner committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    386fe96 View commit details
    Browse the repository at this point in the history

  8. Ran resource generation

    @Kritner
    Kritner committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    26f1e68 View commit details
    Browse the repository at this point in the history

  9. Fix tests, use WorkItem attribute

    @Kritner
    Kritner committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    3b6394c View commit details
    Browse the repository at this point in the history

  10. documentation updates for CA2017

    @Kritner
    Kritner committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    13af907 View commit details
    Browse the repository at this point in the history

  11. Revert "documentation updates for CA2017" 

    This reverts commit 4c41c4e.
    @Kritner
    Kritner committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    11b6ce1 View commit details
    Browse the repository at this point in the history

  12. Trying something else with CA2017 regarding localization 

    * Needed to have a title and description that match *both* potential reasons for this warning
* The individual messages for the differing reasons is still separate, but the MD/sarif description seemed to be "last wins" when it comes to a title/description
* The `msbuild /t:pack` command kept failing for me, so upped the global.json to target a non preview .net8 SDK, but am not checking that change in
    @Kritner
    Kritner committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    b3443e3 View commit details
    Browse the repository at this point in the history

  13. Finish rebase

    @Kritner
    Kritner committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    211c166 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. Take into account escaped braces

    @Kritner
    Kritner committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    7333c4d View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Use CA2023 instead of an overloaded CA2017

    @Kritner
    Kritner committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    eab2278 View commit details
    Browse the repository at this point in the history

  2. Revert "Ran resource generation" 

    This reverts commit 26f1e68.
    @Kritner
    Kritner committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    073302f View commit details
    Browse the repository at this point in the history

  3. Revert "Adds new messages to base resource file" 

    This reverts commit 386fe96.
    @Kritner
    Kritner committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    a3cda94 View commit details
    Browse the repository at this point in the history

  4. Adds new CA2023 information to resources 

    * Will likely need a follow up commit to "undo" the "new" tags around `CA2017`, as these should now match from main
    @Kritner
    Kritner committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    cfc96f4 View commit details
    Browse the repository at this point in the history

  5. Reverts "new" translation indicators back to their previously "transl… 

    …ated" versions from CA2017

* CA2017 was originally repurposed, which caused undesired impacts to already released versions of the analyzer. Instead these changes are introduced as a new CA2023 dotnet#7286 (comment)
    @Kritner
    Kritner committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    880a5d3 View commit details
    Browse the repository at this point in the history

  6. Missed a few files from last commit

    @Kritner
    Kritner committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    59f5fb8 View commit details
    Browse the repository at this point in the history

  7. More covering tests, comment tweaking

    @Kritner
    Kritner committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    6d04bad View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Merge branch 'main' into fix/7285_ca2017

    @Kritner
    Kritner committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    7a46e9f View commit details
    Browse the repository at this point in the history