Stop publishing of additional packages #7282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7282 +/- ##
==========================================
- Coverage 96.48% 96.47% -0.01%
==========================================
Files 1443 1443
Lines 345375 345369 -6
Branches 11362 11362
==========================================
- Hits 333222 333205 -17
- Misses 9273 9284 +11
Partials 2880 2880 |
ViktorHofer
approved these changes
Apr 7, 2024
|
This should not be merged before dotnet/installer#19343. Depending on code flow speed, it could break the VMR build. |
MichaelSimons
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: dotnet/source-build#4204
In the past we've required additional packages to be published to VMR location, during source-build. This was carried over with recent publishing work that modified VMR build to use regular arcade publishing infra - dotnet/source-build#4204
With new changes in dotnet/installer#19343 this is not needed anymore.