Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA2022: Specify IEqualityComparer when creating well known type set #7270

Merged
merged 1 commit into from Mar 27, 2024

Conversation

mpidash
Copy link
Contributor

@mpidash mpidash commented Mar 27, 2024

Follow-up from #7269 (comment).

@mpidash mpidash requested a review from a team as a code owner March 27, 2024 16:09
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.48%. Comparing base (e110f09) to head (c310f5e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7270   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files        1442     1442           
  Lines      345257   345258    +1     
  Branches    11346    11346           
=======================================
+ Hits       333111   333119    +8     
+ Misses       9270     9263    -7     
  Partials     2876     2876           

Copy link
Member

@drewnoakes drewnoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@buyaa-n buyaa-n merged commit ad732e2 into dotnet:main Mar 27, 2024
14 checks passed
@mpidash mpidash deleted the followup-7269 branch March 27, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants