Migrate to 1ES template migration for official builds and mark others accordingly #7253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7253 +/- ##
========================================
Coverage 96.48% 96.48%
========================================
Files 1439 1442 +3
Lines 344369 345212 +843
Branches 11324 11345 +21
========================================
+ Hits 332259 333082 +823
- Misses 9244 9256 +12
- Partials 2866 2874 +8 |
jjonescz
reviewed
Mar 20, 2024
arkalyanms
force-pushed
the
dev/arkalyan/1es-migrate
branch
from
491fef2
to
1314115
Compare
Cosifne
approved these changes
Mar 21, 2024
jjonescz
reviewed
Mar 22, 2024
arkalyanms
force-pushed
the
dev/arkalyan/1es-migrate
branch
from
1314115
to
e2b75a2
Compare
arkalyanms
force-pushed
the
dev/arkalyan/1es-migrate
branch
from
e2b75a2
to
b5e7416
Compare
jjonescz
reviewed
Mar 25, 2024
azure-pipelines-microbuild.yml
Outdated
| outputs: | ||
| # Archive NuGet packages to DevOps. | ||
| - output: pipelineArtifact | ||
| path: $(Build.ArtifactStagingDirectory)/packages/$(BuildConfig) |
There was a problem hiding this comment.
Previously the path was 'artifacts\packages\$(_BuildConfig)' now it's $(Build.ArtifactStagingDirectory)/packages/$(BuildConfig) which seems to resolve to D:\a\_work\1\a\packages\Release which looks different and probably is the reason why you're getting failures in the CI run ##[error]Path does not exist: D:\a\_work\1\a\packages\Release
Applies to the output below as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation build is at https://dev.azure.com/dnceng/internal/_build/results?buildId=2410326&view=results. (SBOM publishing failure warning pending. Should not be a blocker though.)