Add ClassName property to ResxSourceGenerator

[raulsntos]

Allows specifying the fully-qualified class name for the class that will be generated by ResxSourceGenerator.

System.Private.CoreLib specifies the class name System.SR for a resource in Resources\Strings.resx:

https://github.com/dotnet/runtime/blob/8ac30d41d0be7a6de919d765e0143af865371cd4/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj#L32-L37

This allows doing the same with the source generator, the property uses the same name (ClassName):

<EmbeddedResource Update="Resources\Strings.resx">
    <ClassName>System.SR</ClassName>
</EmbeddedResource>

The code for generating with a custom class name already existed, I only exposed it with the ClassName property.

[raulsntos]

@microsoft-github-policy-service agree

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (4af0601) to head (7aba2ca).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7226   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files        1432     1432           
  Lines      342185   342235   +50     
  Branches    11280    11280           
=======================================
+ Hits       330107   330187   +80     
+ Misses       9227     9199   -28     
+ Partials     2851     2849    -2     

[sharwell]

❓ Is this correct? Just want to make sure.

[raulsntos]

There's a comment that explains why this empty type is created:

roslyn-analyzers/src/Microsoft.CodeAnalysis.ResxSourceGenerator/Microsoft.CodeAnalysis.ResxSourceGenerator/AbstractResxGenerator.cs

Lines 573 to 575 in 7aba2ca

	// resource name differs from the access class, need a type for specifying the resources
	// this empty type must remain as it is required by the .NETNative toolchain for locating resources
	// once assemblies have been merged into the application

I'm not sure why we can't use the other type though (NS1.NS2 in this case).

[sharwell]

I'm not sure why I omitted this during the initial implementation. 😆

[raulsntos]

Is there something else I need to do on my end?

[sharwell]

I'm not sure why the system hasn't registered your CLA acceptance. Can you try submitting another PR with something small like a test documentation change to see if it works there?