Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert FixerWithFixAllAnalyzer to a symbol start/stop analyzer #6531

Merged
merged 1 commit into from Mar 14, 2023

Conversation

sharwell
Copy link
Member

Removes the Full Solution Analysis requirement from the following diagnostics:

  • RS1010: Create code actions should have a unique EquivalenceKey for FixAll occurrences support
  • RS1011: Use code actions that have a unique EquivalenceKey for FixAll occurrences support
  • RS1016: Code fix providers should provide FixAll support

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #6531 (bcc29c8) into main (5212c6e) will decrease coverage by 0.01%.
The diff coverage is 93.18%.

❗ Current head bcc29c8 differs from pull request most recent head 4320a30. Consider uploading reports for the commit 4320a30 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6531      +/-   ##
==========================================
- Coverage   96.42%   96.42%   -0.01%     
==========================================
  Files        1372     1372              
  Lines      319898   319881      -17     
  Branches    10275    10271       -4     
==========================================
- Hits       308455   308438      -17     
- Misses       8984     8985       +1     
+ Partials     2459     2458       -1     

Removes the Full Solution Analysis requirement from the following diagnostics:

* RS1010: Create code actions should have a unique EquivalenceKey for FixAll occurrences support
* RS1011: Use code actions that have a unique EquivalenceKey for FixAll occurrences support
* RS1016: Code fix providers should provide FixAll support
@sharwell sharwell enabled auto-merge March 14, 2023 13:39
@sharwell sharwell merged commit cc75004 into dotnet:main Mar 14, 2023
@github-actions github-actions bot added this to the vNext milestone Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants