Enable concurrent execution #6357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we want to try updating the 2.9.x branch. It has been dormant for quite a while and unless there is an absolute need we want to avoid fixing anything here. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6357 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 1361 1361
Lines 316034 316035 +1
Branches 10192 10192
=======================================
+ Hits 303741 303746 +5
+ Misses 9861 9858 -3
+ Partials 2432 2431 -1 |
buyaa-n
reviewed
May 12, 2023
| { | ||
| //analysisContext.EnableConcurrentExecution(); | ||
| context.EnableConcurrentExecution(); |
There was a problem hiding this comment.
So it is safe to enable it now? (The reference in the issue had a comment // TODO: Make analyzer thread-safe. Could not find from history how its removed or who removed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2068
@mavasani I'm assuming 2.9.x is the correct branch? Let me know if I should rebase on main branch
Note: I don't see any concurrency issues in the implementation, but this needs to be carefully confirmed.