Respect editorconfig var preference in CA1854 #6023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Youssef1313
force-pushed
the
var-user-preference
branch
from
e9da5c3
to
8ce8f17
Compare
Codecov Report
@@ Coverage Diff @@
## main #6023 +/- ##
=======================================
Coverage 96.03% 96.03%
=======================================
Files 1338 1338
Lines 307108 307164 +56
Branches 9785 9787 +2
=======================================
+ Hits 294917 294974 +57
+ Misses 9814 9812 -2
- Partials 2377 2378 +1 |
buyaa-n
reviewed
Jun 9, 2022
| var model = await context.Document.GetSemanticModelAsync(context.CancellationToken).ConfigureAwait(false); | ||
| if (model.GetTypeInfo(dictionaryAccess).Type is not { } type) | ||
| { | ||
| return; |
There was a problem hiding this comment.
Not sure if the type is always available, probably should use var if it is not
|
Thanks @Youssef1313, looks good to me except it is not covered the variable name duplication part of #6022, could you cover that with this PR? We can still merge this PR without that and leave the issue open for that part |
|
I'll take a look at the duplication issue later. The fix will likely be using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6022