Use nullable references in security rules #3110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavasani
reviewed
Dec 12, 2019
src/Microsoft.NetFramework.Analyzers/Core/Helpers/SecurityDiagnosticHelpers.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Dec 12, 2019
src/Microsoft.NetFramework.Analyzers/Core/Helpers/SecurityDiagnosticHelpers.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Dec 12, 2019
| @@ -274,7 +277,7 @@ public static string GetNonEmptyParentName(SyntaxNode current, SemanticModel mod | |||
| /// For .NET Framework 4.X, this method returns the actual framework version instead of assembly verison of mscorlib, | |||
| /// i.e. for .NET framework 4.5.2, this method return 4.5.2 instead of 4.0.0.0. | |||
| /// </remarks> | |||
| public static Version GetDotNetFrameworkVersion(Compilation compilation) | |||
| public static Version? GetDotNetFrameworkVersion(Compilation compilation) | |||
| { | |||
| if (compilation == null || !IsTypeDeclaredInExpectedAssembly(compilation, "System.String", "mscorlib").GetValueOrDefault()) | |||
There was a problem hiding this comment.
@sharwell Do you know why compiler does not generate any warning for parameter not being declared nullable when the code has a null check up front?
mavasani
reviewed
Dec 12, 2019
src/Microsoft.NetFramework.Analyzers/Core/Helpers/SecurityDiagnosticHelpers.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Dec 13, 2019
| @@ -71,7 +71,7 @@ private static void GetRulesJson(string nugetInstalledPackagesPath, string versi | |||
| if (!RoslynString.IsNullOrWhiteSpace(latestRulesJsonPath)) | |||
| { | |||
| RuleFileContent latestContent = ReadRuleFileContent(latestRulesJsonPath); | |||
| Dictionary<string, RuleInfo> latestRulesById = latestContent.Rules.ToDictionary(r => r.Id); | |||
| Dictionary<string?, RuleInfo> latestRulesById = latestContent.Rules.ToDictionary(r => r.Id); | |||
mavasani
approved these changes
Dec 13, 2019
|
Thank you, @mavasani ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3069 - XML rules, which I will reimplement with DFA one year.