Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #2900
From my observations with slow analysis with DoNotHardCodeEncryptionKey, the root cause is a combination of ValueContent analysis can be slow and ValueContentAnalysisResult cache misses, due to the limited DFA result cache. That causes ValueContent analysis to be invoked multiple times.
This somewhat mitigates the problem, by caching analysis on a per-analyzer-operationblock basis, in TaintedData analyzers that use ValueContentAnalysis.
Longer term we should see if we can come up with a way of caching DFA results on a per compilation basis without memory leaks, and see what we can do to optimize ValueContent analysis.