Fix NRE in AssigningSymbolAndItsMemberInSameStatement analyzer #2894
Conversation
| @@ -80,8 +80,8 @@ private void AnalyzeAssignment(OperationAnalysisContext context) | |||
| { | |||
| assignmentOperation = (ISimpleAssignmentOperation)assignmentOperation.Value; | |||
|
|
|||
| var operationValue = assignmentOperation.Target as T; | |||
There was a problem hiding this comment.
Time to start dogfooding C# 8 nullable references in the repo :-)
Any takers @dotnet/roslyn-analysis? Otherwise, I will try to get to it next sprint.
There was a problem hiding this comment.
We had a similar NRE just a few weeks ago: https://github.com/dotnet/roslyn-analyzers/pull/2762/files
There was a problem hiding this comment.
Is it just a matter of bumping roslyn version? Or are you actually proposing a full scale NRT roll out in this repo? :)
In reply to: 330693127 [](ancestors = 330693127)
There was a problem hiding this comment.
We can do staged work if that is easier :) Planning to bump master branch to MS.CA 3.0 soon.
There was a problem hiding this comment.
I suspect we might need to annotate the analyzer/codefix API's first in Roslyn, to have a cleaner annotation here.
Fixes #2889