Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce that symbol comparison should use an equality comparer #2764

Merged
merged 11 commits into from Oct 1, 2019
Merged

Enforce that symbol comparison should use an equality comparer #2764

merged 11 commits into from Oct 1, 2019

Commits on Aug 14, 2019

  1. Report a rule when the 'Equals' method is called with only ISymbol

    @ryzngard
    ryzngard committed Aug 14, 2019
    Copy the full SHA
    08b0b65 View commit details
    Browse the repository at this point in the history

  2. Update rule message to reflect new guidance

    @ryzngard
    ryzngard committed Aug 14, 2019
    Copy the full SHA
    fcbe3de View commit details
    Browse the repository at this point in the history

  3. Add missing return statement

    @ryzngard
    ryzngard committed Aug 14, 2019
    Copy the full SHA
    69a84ba View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2019

  1. Limit to only if SymbolEquivalenceComparer exists

    @ryzngard
    ryzngard committed Aug 19, 2019
    Copy the full SHA
    7c91a28 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2019

  1. Fix logic change to be same as before change

    @ryzngard
    ryzngard committed Aug 20, 2019
    Copy the full SHA
    df8059d View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2019

  1. Undo resx change

    @ryzngard
    ryzngard committed Sep 3, 2019
    Copy the full SHA
    b2bc750 View commit details
    Browse the repository at this point in the history

  2. Add code fix for equality comparer

    @ryzngard
    ryzngard committed Sep 3, 2019
    Copy the full SHA
    911e3e0 View commit details
    Browse the repository at this point in the history

  3. update code fixer to handle when comparer should be used

    @ryzngard
    ryzngard committed Sep 3, 2019
    Copy the full SHA
    115349a View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2019

  1. Fix test

    @ryzngard
    ryzngard committed Sep 4, 2019
    Copy the full SHA
    ca36410 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2019

  1. Merge branch 'master' into feature/catch_isymbol_equals_without_comparer

    @ryzngard
    ryzngard committed Sep 25, 2019
    Copy the full SHA
    3842562 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2019

  1. Add test for Equal -> EqualityComparer

    @ryzngard
    ryzngard committed Sep 26, 2019
    Copy the full SHA
    3bc68a1 View commit details
    Browse the repository at this point in the history