Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TODO comments to enable nullable reference types in security analyzers #3069

Closed
mavasani opened this issue Nov 26, 2019 · 1 comment
Closed

Fix TODO comments to enable nullable reference types in security analyzers #3069

mavasani opened this issue Nov 26, 2019 · 1 comment
Assignees
@dotpaul
Labels
Area-Microsoft.CodeAnalysis.NetAnalyzers Category-Security

Comments

@mavasani
Copy link
Member

#3021 enabled nullable reference types for the repo, but a bunch of security analyzers and analysis files were opted out. @dotpaul, we need to fix the following two buckets of suppressions:

// TODO(dotpaul): Enable nullable analysis.
#nullable disable
// TODO(dotpaul): Remove the below suppression.
@mavasani mavasani added this to the vNext milestone Nov 26, 2019
@dotpaul dotpaul mentioned this issue Dec 12, 2019
Merged
@mavasani
Copy link
Member Author

@dotpaul can be closed?

@dotpaul dotpaul closed this as completed Dec 23, 2019
@jmarolf jmarolf modified the milestones: vNext, .NET 5 Preview 8 Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dotpaul dotpaul

Labels
Area-Microsoft.CodeAnalysis.NetAnalyzers Category-Security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmarolf @mavasani @dotpaul