Ix: Do not dispose the enumerator while enumerating in the ToObservable operator.

Ix.NET/Source/System.Linq.Async/System/Linq/Operators/ToObservable.cs

@@ -3,7 +3,6 @@
 // See the LICENSE file in the project root for more information. 
 
 using System.Collections.Generic;
-using System.Threading.Tasks;
 
 namespace System.Linq
 {
@@ -32,30 +31,35 @@ public IDisposable Subscribe(IObserver<T> observer)
 
                 async void Core()
                 {
-                    try
+                    // REVIEW: fire-and-forget DisposeAsync?
+                    await using (var e = _source.GetAsyncEnumerator(ctd.Token))
                     {
-                        await foreach (var element in _source.WithCancellation(ctd.Token).ConfigureAwait(false))
+                        do
                         {
-                            observer.OnNext(element);
+                            bool hasNext;
+                            try
+                            {
+                                hasNext = await e.MoveNextAsync().ConfigureAwait(false);
+                            }
+                            catch (Exception ex)
+                            {
+                                if (!ctd.Token.IsCancellationRequested)
+                                {
+                                    observer.OnError(ex);
+                                }
 
-                            if (ctd.Token.IsCancellationRequested)
+                                return;
+                            }
+
+                            if (!hasNext)
                             {
+                                observer.OnCompleted();
                                 return;
                             }
-                        }
-                    }
-                    catch (Exception error)
-                    {
-                        if (!ctd.Token.IsCancellationRequested)
-                        {
-                            observer.OnError(error);
-                        }
-                        return;
-                    }
 
-                    if (!ctd.Token.IsCancellationRequested)
-                    {
-                        observer.OnCompleted();
+                            observer.OnNext(e.Current);
+                        }
+                        while (!ctd.Token.IsCancellationRequested);
                     }
                 }