Don't add duplicate FrameworkReference

[ltrzesniewski]

This PR adds a check to avoid adding a duplicate FrameworkReference item for Microsoft.WindowsDesktop.App, which caused the following warning:

warning NETSDK1086: A FrameworkReference for 'Microsoft.WindowsDesktop.App' was included in the project. This is implicitly referenced by the .NET SDK and you do not typically need to reference it from your project. For more information, see https://aka.ms/sdkimplicitrefs

The item was duplicated as it had different metadata:

I'm not sure why that FrameworkReference item is needed (it was introduced in #1007), so there may be a better solution for this.

Fixes #1112

[ghost]

Hi, is this issue resolved? I am still getting it in a .NET Core 3.1 WPF application using System.Reactive version 4.4.1.

[ltrzesniewski]

@arlvin it's resolved, but not deployed - v4.4.1 does not include this fix.

[ghost]

@arlvin it's resolved, but not deployed - v4.4.1 does not include this fix.

@ltrzesniewski Thanks for the response. Any idea when it may be deployed?

[ltrzesniewski]

I don't know, but I'm interested as well. @clairernovotny do you know when the next release will be?

[girishnuli]

Is this issue resolved? Same issue as @arlvin - getting the warning in a .Net Core 3.1 WPF app

[ghost]

@girishnuli I see there's a version 5.0.0-preview.16 from 11 days ago. I'll try that one out and see.

[ghost]

Ahhh, @girishnuli I'm happy to see that the issue is resolved in the preview package that i mentioned above! I hope the final version will be out soon.

[girishnuli]

@arlvin Thanks for checking and confirming it is resolved. Looking forward to the final version.

[ghost]

@girishnuli Version 5 has finally been released and I've updated my project, yey!!!