Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tail recursion with while loop #1088

Closed

Conversation

bartholinie
Copy link

@bartholinie bartholinie commented Nov 20, 2019

Fixes #1087

@dnfclas
Copy link

dnfclas commented Nov 20, 2019

CLA assistant check
All CLA requirements met.

@dnfclas
Copy link

dnfclas commented Nov 20, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ bartholinie sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@quinmars
Copy link
Contributor

Note, that #915 also removes the tail recursion.

@akarnokd
Copy link
Collaborator

I prefer #915 too. @quinmars Could you add the test from this PR to yours?

@quinmars
Copy link
Contributor

I will do that this evening (CET). I hopefully can preserve the authorship with cherry picking.

@danielcweber
Copy link
Collaborator

Fixed by #915. Unit test from this PR made it there. Thank you for the effort.

@bartholinie bartholinie deleted the ReplaceTailRecursionWithWhileLoop branch November 21, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AsyncEnumerable.ToObservable() uses tail recursion and overflows the stack
5 participants