Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on invalid NuGet configuration #10220

Merged
merged 8 commits into from
Apr 5, 2024
Merged

Warn on invalid NuGet configuration #10220

merged 8 commits into from
Apr 5, 2024

Conversation

jaredpar
Copy link
Member

@jaredpar jaredpar commented Apr 4, 2024

Issue a warning when %NUGET_PACKAGES% doesn't have a trailing slash until the associatede issue is fixed.

dotnet/roslyn#72657

Issue a warning when `%NUGET_PACKAGES%` doesn't have a trailing slash
until the associatede issue is fixed.

dotnet/roslyn#72657
@jaredpar jaredpar marked this pull request as ready for review April 4, 2024 20:09
@DustinCampbell
Copy link
Member

🤣 You broke your own build.

@jaredpar
Copy link
Member Author

jaredpar commented Apr 4, 2024

You broke your own build.

Been one of those days 😆

@jaredpar jaredpar requested review from a team as code owners April 4, 2024 21:05
@jaredpar jaredpar merged commit 6c02086 into main Apr 5, 2024
12 checks passed
@jaredpar jaredpar deleted the dev/jaredpar/warn branch April 5, 2024 15:08
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 5, 2024
@Cosifne Cosifne modified the milestones: Next, 17.11 P2 May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants