Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding benchmarks from Akade.IndexedSet #3410

Merged
merged 6 commits into from
Nov 20, 2023
Merged

Adding benchmarks from Akade.IndexedSet #3410

merged 6 commits into from
Nov 20, 2023

Conversation

akade
Copy link
Contributor

@akade akade commented Oct 12, 2023

I was asked in dotnet/runtime#90101 by @AndyAyersMS if I would like to include the benchmarks from my nuget package in this repo and I finally found the time to so. Including a few less synthetic benchmarks.

Snapshot of benchmarks akade/Akade.IndexedSet@eacb9a8 but only including the benchmarks concerning the library itself - leaving out any comparison benchmarks.

I followed the lines of the ImageSharp benchmarks, but I have the following remaining questions:

  • How can I get the nuget package listed in the configured sources? I removed the clear for now...
  • Do you have limits for the runtime for all the benchmark? Currently, running through all of them in .NET 8 takes about 12min on my machine. I might be able to tune that a bit on the amount of data the real-world-benchmarks are run against.

Anything else that I need to do to?

@akade
Copy link
Contributor Author

akade commented Oct 12, 2023

@dotnet-policy-service agree

NuGet.config Outdated Show resolved Hide resolved
@cincuranet cincuranet self-assigned this Oct 17, 2023
@cincuranet
Copy link
Contributor

@akade Also the azure-pipelines.yml needs to be modified to run these benchmarks. It will be basically the same as "ImageSharp" parts.

@AndyAyersMS Do you want to run on standard set of platforms we do for real-world benchmarks or something in particular?

@AndyAyersMS
Copy link
Member

@AndyAyersMS Do you want to run on standard set of platforms we do for real-world benchmarks or something in particular?

The standard set.

@akade akade marked this pull request as ready for review October 30, 2023 19:36
@cincuranet
Copy link
Contributor

@akade Sorry for this taking so long. I was bit busy with other stuff. The packages are now mirrored in dotnet-public feed, I fixed the MD problem linter was complaining about and finally fixed the typo in azure-pipelines.yml file. If (fingers crossed) everything goes smoothly, I'll merge it and prepare all the reporting and data ingestion tomorrow.

@cincuranet
Copy link
Contributor

Failures are unrelated. Merging.

@cincuranet cincuranet merged commit 73a1e1d into dotnet:main Nov 20, 2023
30 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants