Define VSToolsPath property properly #8090
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6607
Context
MSBuild theoretically defines the VSToolsPath property in its app.config/app.amd.config files, but it doesn't actually fire in practice. (You can tell since two of the properties next to it were pulled out and properly defined elsewhere, and that didn't cause "duplicate definition" errors.)
Changes Made
Move both the VSToolsPath and the MSBuildExtensionsPath64 out of the condition and give them proper values. I did have to hardcode 17.0, but that is done in several other places, so I think it appropriate.
Testing
I tried the provided repro before and after this change. This made it not happen anymore.
Also added a unit test.