Revert #7454 to fix double-DeepCopy regression #7588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts (dotnet#7454)" This reverts commit e39a9be. Fixes a regression caused by the fix, tracked as https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1526076.
marcpopMSFT
approved these changes
Apr 29, 2022
Forgind
approved these changes
Apr 29, 2022
benvillalobos
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work item (Internal use): AB#1526076
Summary
Revert #7454, which regressed VS user scenarios around shared projects.
Customer Impact
Users with that use shared projects get build failures with no workaround. Because of the nature of the bug (a clone of a clone fails) there may be more scenarios that start failing after more use--this was introduced in Preview 3 so hasn't seen much use.
Regression?
Yes, from 17.2 preview 2.
Testing
Unit tests + targeted scenario test.
Risk
Low since it's a revert. It does reintroduce #7435, but that's a longstanding bug and we've confirmed with the reporter that it can be worked around.