Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share read for text resource files #7230

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

rainersigwald
Copy link
Member

Fixes #7229 by ensuring that MSBuild's processing of a .txt resource holds only the minimal lock: open for read and allowing other processes to read while it's open.

Fixes dotnet#7229 by ensuring that MSBuild's processing of a `.txt` resource holds only the minimal lock: open for read and allowing other processes to read while it's open.
@rainersigwald rainersigwald added this to the VS 17.1 milestone Jan 7, 2022
Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, but is this 17.1-worthy? It isn't a major source of customer pain, as far as I know.

@rainersigwald rainersigwald changed the base branch from vs17.1 to main January 7, 2022 17:40
@rainersigwald rainersigwald modified the milestones: VS 17.1, VS 17.2 Jan 7, 2022
@Forgind Forgind merged commit 64edb33 into dotnet:main Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race condition on text resources processed in multiple project instances
3 participants