Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NoWarn to .xsd #7089

Merged
merged 2 commits into from Nov 29, 2021
Merged

Add NoWarn to .xsd #7089

merged 2 commits into from Nov 29, 2021

Conversation

KirillOsenkov
Copy link
Member

No description provided.

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Nov 29, 2021
rainersigwald
rainersigwald reviewed Nov 29, 2021
View reviewed changes
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is tough because the details vary across versions but I think this is accurate enough for all versions and is certainly an improvement. Thanks!

@rainersigwald rainersigwald mentioned this pull request Nov 29, 2021
Open
@rainersigwald rainersigwald merged commit 7ead524 into main Nov 29, 2021
@rainersigwald rainersigwald deleted the dev/kirillo/nowarn branch November 29, 2021 17:50
@Forgind Forgind mentioned this pull request Dec 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainersigwald rainersigwald rainersigwald approved these changes

@Forgind Forgind Forgind approved these changes

Assignees
No one assigned
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KirillOsenkov @rainersigwald @Forgind