Update System.Text.Json to 5.0.2 #6784
Conversation
|
Need to also update both app configs: https://github.com/dotnet/msbuild/search?q=system.text.json |
It's already there. |
|
We should definitely kick off an experimental branch before merging this. |
benvillalobos
added
the
exp-branch
| </dependentAssembly> | ||
| <dependentAssembly> | ||
| <assemblyIdentity name="System.Text.Json" publicKeyToken="cc7b13ffcd2ddd51" culture="neutral" /> | ||
| <bindingRedirect oldVersion="0.0.0.0-4.0.1.0" newVersion="4.0.1.0" /> | ||
| <bindingRedirect oldVersion="0.0.0.0-5.0.0.2" newVersion="5.0.0.2" /> |
There was a problem hiding this comment.
Should we also add binding redirects for System.ValueTuple as we did for VS so that a 4.0.3.0 binding can load the 4.0.0.0 one from the GAC?
There was a problem hiding this comment.
@rainersigwald Thoughts?
I'm tempted to leave as-is. The binding redirects in VS were really just for tests ...
There was a problem hiding this comment.
Counter point: For consistency of devenv.exe and msbuild.exe ... it might make sense to have the same redirects.
There was a problem hiding this comment.
No, the binding redirects in VS were not just for tests. Folks can reference 4.0.0.0 or 4.0.3.0 during compilation (among others). The CLR will not bind 4.0.3.0 to 4.0.0.0 (or 4.0.0.0 to 4.0.3.0) without binding redirects. VS must have redirects or else our very diverse codebase won't always run together. MSBuild tasks come from 3rd parties as well so IMO it behooves msbuild to have binding redirects for all the assemblies it ships (or doesn't by relying on the GAC) as well.
There was a problem hiding this comment.
I think it makes sense to have the binding redirect (we're trying to be consistent about that, see #6334) and also for it to be the same as VS's (down to 4.0.0.0).
There was a problem hiding this comment.
Pushed a change to do this (and pull it from our VSIX).
There was a problem hiding this comment.
(I meant they were just to get tests to pass since the runner couldn't pull in newer) but you're right! Sounds good!
Match the VS-side binding redirects that force the use of 4.0.0.0 in all cases. Stop carrying a copy, since it will now always be found in the GAC as part of .NET 4.7.2+, required by VS. https://devdiv.visualstudio.com/DevDiv/_git/VS?path=%2Fsrc%2Fappid%2Fcommon%2Fcorefx.config.ttinclude&version=GBmain&line=93&lineEnd=101&lineStartColumn=1&lineEndColumn=29&lineStyle=plain&_a=contents
rainersigwald
force-pushed
the
jakerad/update-system-text-json
branch
from
94b31ca
to
e16b4a0
Compare
|
Thanks @JakeRadMSFT! |
Fixes conflicts in VS 2022 for extensions that would like to use libraries that need System.Text.Json 5.0.0 or newer.
Context
Fixes conflicts in VS 2022 for extensions that would like to use libraries that need System.Text.Json 5.0.0 or newer.
Changes Made
Updated packages.
Testing
None :)
Notes