Remove import using CoreCrossTargetingTargetsPath property
#6668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The import based on this property was introduced as a temporary bootstrapping mechanism before there was packaging extensibility available for multi-targeting. The packaging mechanism (aka NuGet) now uses 'buildCrossTargeting'/'buildMultiTargeting', similar to 'build' package folder to hold and import multi-targeting logic via NuGet's Restore. Thus, we don't need this workaround anymore.
Forgind
approved these changes
Jul 15, 2021
benvillalobos
approved these changes
Jul 19, 2021
Forgind
added
the
merge-when-branch-open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1062
Context
The import based on this property was introduced as a temporary bootstrapping
mechanism before there was packaging extensibility available for multi-targeting.
The packaging mechanism (aka NuGet) now uses
buildCrossTargeting/buildMultiTargeting,similar to
buildpackage folder to hold and import multi-targeting logic via NuGet's Restore.Thus, we don't need this workaround anymore.
Changes Made
Removed the temporary import based on
CoreCrossTargetingTargetsPathTesting
Since there are no tests for this property, as it is with all the workarounds… We'll see if we break anyone during the self-hosting period.
Notes
This patch was already a part of #6161. Since, the change was approved independently, I have separated this into a new PR.