Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servicing fixes for 16.10.2 #6537

Merged
merged 5 commits into from
Jun 8, 2021
Merged

Commits on Jun 3, 2021

  1. Fix MakeRelative regression in v16.10

    Added some more unit tests as per suggestions
    
    Fixed unit test failing on linux
    
    Removed unnecessary length check
    
    Co-authored-by: Forgind <Forgind@users.noreply.github.com>
    dsparkplug and Forgind committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    149c776 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fe2c68f View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2021

  1. Don't move Properties and Items to ProjectEvaluationFinished if legac…

    …y loggers present
    
    Switch from the "use the new logic if any logger is present that supports it" to the more conservative "use the old logic if any logger doesn't support the new logic".
    
    There are legacy loggers such as the Azure DevOps logger that crash if ProjectStartedEventArgs.Properties is null.
    
    Both console loggers also need more work to properly support the new logic.
    
    Effectively the new logic will now only take place when the binary logger is the only logger.
    KirillOsenkov authored and rainersigwald committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    794abcb View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2021

  1. Introduce IsAllFilesWildcard() and call it from MatchFileRecursionStep

    Fixes dotnet#6502
    
    Summary
    
    This change fixes a regression in glob matching where files without extension are erroneously not matched when taking a specific globbing code path.
    
    Customer impact
    
    Any customer who uses a glob pattern susceptible to the bug and has files without extensions in their source tree is affected. The bug was reported by external customers.
    
    Regression?
    
    Yes, caused by dotnet#6151 where glob matching was optimized which internally made it take a different code path.
    
    Changes Made
    
    Fixes the regression by properly handling `*.*` to mean all files, not just files with a dot in the name. This convention is used in .NET APIs on all platforms and matches the pre-regression behavior.
    
    Testing
    
    Added unit test coverage. Also verified locally with the repro provided by the original bug reporter.
    
    Risk
    
    Low. The star patterns are special-cased to mean all files, other patterns are unaffected.
    ladipro authored and rainersigwald committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    de3f28e View commit details
    Browse the repository at this point in the history
  2. Merge branches 'fix-makerelative', 'dev/kirillo/notAllLoggers', and '…

    …6502-fix-wildcard-glob-matching-16.11' into 'vs16.10'
    rainersigwald committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    ac8275b View commit details
    Browse the repository at this point in the history