Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't move Properties and Items to ProjectEvaluationFinished if legacy loggers present #6520

Merged
merged 1 commit into from Jun 8, 2021

Commits on Jun 7, 2021

  1. Don't move Properties and Items to ProjectEvaluationFinished if legac…

    …y loggers present
    
    Switch from the "use the new logic if any logger is present that supports it" to the more conservative "use the old logic if any logger doesn't support the new logic".
    
    There are legacy loggers such as the Azure DevOps logger that crash if ProjectStartedEventArgs.Properties is null.
    
    Both console loggers also need more work to properly support the new logic.
    
    Effectively the new logic will now only take place when the binary logger is the only logger.
    KirillOsenkov authored and rainersigwald committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    794abcb View commit details
    Browse the repository at this point in the history