Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for embedding arbitrary files into binlog #6339

Merged
merged 3 commits into from Apr 21, 2021

Commits on Apr 10, 2021

  1. Add support for embedding arbitrary files into binlog

    It would be very useful to embed more than just the project files into the binlog. For example, project.assets.json is a common request: #3529. global.json or nuget.config would be other examples. Some users may want to embed all *.cs files as well.
    
    Add a special EmbedInBinlog item type recognized by BuildEventArgsWriter. If after evaluation the items contain EmbedInBinlog, all such items will be logged if the evaluated include points to a full file path that exists on disk. A given file can be mentioned more than once, but will only be embedded once. If a file doesn't exist or is empty, it will not be embedded. If the item is added from a target (after evaluation is done), it will not be embedded.
    
    Checking for EmbedInBinlog is done in BuildEventArgsWriter to reuse the complicated and performance-optimized logic of iterating over all items.
    KirillOsenkov committed Apr 10, 2021
    Copy the full SHA
    1d97b48 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. Copy the full SHA
    92632a9 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. Copy the full SHA
    efec80c View commit details
    Browse the repository at this point in the history