Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous logging improvements #6326

Merged
merged 14 commits into from Apr 20, 2021
Merged

Miscellaneous logging improvements #6326

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c09a537
Don't log BuildEventArgs.Message where it can be reconstructed.
KirillOsenkov Apr 5, 2021
c9b5e2e
Log TaskParameterEventArgs for inputs/outputs of TargetSkipped
KirillOsenkov Apr 5, 2021
ace9956
Do not allocate a single string for Task Parameter
KirillOsenkov Apr 5, 2021
66acffd
Do not log property reassignment for MSBuildAllProjects
KirillOsenkov Apr 5, 2021
b6540bc
Cache resource strings in RAR logging.
KirillOsenkov Apr 5, 2021
95021b1
Cache resource strings in the Copy task.
KirillOsenkov Apr 5, 2021
c191e15
Use named arguments.
KirillOsenkov Apr 5, 2021
da331c9
Add NOPERFORMANCESUMMARY switch for console loggers.
KirillOsenkov Apr 5, 2021
e270fea
Add TestLoggingForSkippedTargetInputsAndOutputs
KirillOsenkov Apr 5, 2021
6fea565
Compare console logs after binary logging roundtrip.
KirillOsenkov Apr 5, 2021
1de22cd
Add more coverage for console logs from binlog playback.
KirillOsenkov Apr 5, 2021
785ffa1
Fix test to work on unix.
KirillOsenkov Apr 5, 2021
2410c41
Fix typo: HelpHeyword -> HelpKeyword.
KirillOsenkov Apr 8, 2021
ca456ad
Add GetResourceEightSpaces
KirillOsenkov Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/Build/Logging/BaseConsoleLogger.cs
View file
Open in desktop
Expand Up @@ -908,14 +908,14 @@ public virtual void Initialize(IEventSource eventSource, int nodeCount)
/// <param name="eventSource">Available events.</param>
public virtual void Initialize(IEventSource eventSource)
{
ParseParameters();

// Always show perf summary for diagnostic verbosity.
if (IsVerbosityAtLeast(LoggerVerbosity.Diagnostic))
{
this.showPerfSummary = true;
}

ParseParameters();

showTargetOutputs = !String.IsNullOrEmpty(Environment.GetEnvironmentVariable("MSBUILDTARGETOUTPUTLOGGING"));

if (showOnlyWarnings || showOnlyErrors)
Expand Down Expand Up @@ -975,6 +975,9 @@ internal virtual bool ApplyParameter(string parameterName, string parameterValue
case "PERFORMANCESUMMARY":
showPerfSummary = true;
return true;
case "NOPERFORMANCESUMMARY":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

showPerfSummary = false;
return true;
case "NOSUMMARY":
ShowSummary = false;
return true;
Expand Down