Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly Consider WarningsAsMessages In TaskLoggingHelper's HasLoggedErrors #6308

Merged
merged 8 commits into from Mar 31, 2021
Merged

Properly Consider WarningsAsMessages In TaskLoggingHelper's HasLoggedErrors #6308

merged 8 commits into from Mar 31, 2021

Commits on Mar 29, 2021

  1. Pass warningsasmessages to the taskhost. Add GetWarningsAsMessages to… 

    … the logging service and taskloggingcontext
    @benvillalobos
    benvillalobos committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    1b8e748 View commit details
    Browse the repository at this point in the history

  2. Pass warningsasmessages to OOPTHN

    @benvillalobos
    benvillalobos committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    f2de8f7 View commit details
    Browse the repository at this point in the history

  3. Add test for warningsasmessages serialization. Code consistenty betwe… 

    …en OOPTHN and TH
    @benvillalobos
    benvillalobos committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    949f239 View commit details
    Browse the repository at this point in the history

  4. Add test cases for warnaserr and warnasmessage

    @benvillalobos
    benvillalobos committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    810a85b View commit details
    Browse the repository at this point in the history

  5. PR Feedback: Simplify GetWarningsAsMessages and Errors

    @benvillalobos
    benvillalobos committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    0d44724 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Streamline tests, remove unnecessary test

    @benvillalobos
    benvillalobos committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    0559707 View commit details
    Browse the repository at this point in the history

  2. Fix taskreturnstrue tests

    @benvillalobos
    benvillalobos committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    8b6356c View commit details
    Browse the repository at this point in the history

  3. PR Feedback: Code cleanup. Pass IEqualityComparer under CLR2

    @benvillalobos
    benvillalobos committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    9e36efd View commit details
    Browse the repository at this point in the history