Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serializable project evaluation related changes #6261

Closed
wants to merge 2 commits into from

Conversation

jackcartman
Copy link
Contributor

@jackcartman jackcartman commented Mar 15, 2021

Fixes #6260

Context

The evaluation result is being cached now on the CPS side to speed up solution load. For the cases where CPS has it's linked read-only Project, we would like to create a ProjectInstance as well from it, instead of triggering a evaluation for the sake of creating a ProjectInstance

Changes Made

  • Add a constructor to ProjectInstance that builds itself from the Project.
  • Also exposed the existing GetAllGlobs override to ProjectLink. Previously never exposed since ProjectLink was used only for csproj that does not really care about globs.

Testing

Added a test for the new constructor.

Notes

The PR is triggered from my personal github account because @arkalyanms is locked out at the moment and is still in recovery.

@dnfadmin
Copy link

dnfadmin commented Mar 15, 2021

CLA assistant check
All CLA requirements met.

@dnfadmin
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ jackcartman sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@jackcartman
Copy link
Contributor Author

@ladipro, @Forgind, @benvillalobos: I've started a PR from my personal account since my work account @arkalyanms is still in recovery. Not sure if you'd recommend waiting for the account to be unlocked or if you could review and authorize the merge for me.

@Forgind
Copy link
Member

Forgind commented Mar 15, 2021

Not a problem. I should be able to take a look at some point this week.
cc @cdmihai

@jackcartman
Copy link
Contributor Author

Replaced with exp branch based PR - #6262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serializable MSBuild.Project support
4 participants