Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tasks Log.HasLoggedError now respects MSBuildWarningsAsErrors #6174

Merged
merged 32 commits into from Mar 13, 2021
Merged

Tasks Log.HasLoggedError now respects MSBuildWarningsAsErrors #6174

merged 32 commits into from Mar 13, 2021

Commits on Feb 8, 2021

  1. Add IBuildEngine8 with a hashset of all warnings to be logged as errors

    @benvillalobos
    benvillalobos committed Feb 8, 2021
    Copy the full SHA
    8ca466d View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. Add GetWarningsAsErrors method to ILoggingService. TaskLoggingHelper … 

    …checks BuildEngine.WarningsAsErrors before logging warnings. TaskHost calls GetWarningsAsErrors from ILoggingService
    @benvillalobos
    benvillalobos committed Feb 9, 2021
    Copy the full SHA
    ff95db2 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2021

  1. Try adding warningsaserrors into taskhostconfiguration so OOP taskhos… 

    …t knows what warningsaserrors are.
    @benvillalobos
    benvillalobos committed Feb 16, 2021
    Copy the full SHA
    16cd7f0 View commit details
    Browse the repository at this point in the history

  2. TaskHostConfiguration now translates warningsaserrors

    @benvillalobos
    benvillalobos committed Feb 16, 2021
    Copy the full SHA
    2b61f12 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. Update src/Utilities/Task.cs 

    Co-authored-by: Forgind <Forgind@users.noreply.github.com>
    @benvillalobos @Forgind
    benvillalobos and Forgind committed Feb 19, 2021
    Copy the full SHA
    07fbbb7 View commit details
    Browse the repository at this point in the history

  2. run build.cmd and update ref files

    @benvillalobos
    benvillalobos committed Feb 19, 2021
    Copy the full SHA
    8da9849 View commit details
    Browse the repository at this point in the history

  3. WarningsAsErrors can be null if not specified

    @benvillalobos
    benvillalobos committed Feb 19, 2021
    Copy the full SHA
    8f58790 View commit details
    Browse the repository at this point in the history

  4. Null check on warningsaserrors instead of buildengine

    @benvillalobos
    benvillalobos committed Feb 19, 2021
    Copy the full SHA
    cf90ca0 View commit details
    Browse the repository at this point in the history

  5. Unit Test: Add check for tasks logging warnings that are turned into … 

    …errors. Add Task that logs a warning and returns !Log.HasLoggedErrors (as standard tasks tend to do)
    @benvillalobos
    benvillalobos committed Feb 19, 2021
    Copy the full SHA
    fda18f5 View commit details
    Browse the repository at this point in the history

  6. Ensure build stops when task logs a warning->error

    @benvillalobos
    benvillalobos committed Feb 19, 2021
    Copy the full SHA
    4a93c5a View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2021

  1. Add test for translation of taskhostconfiguration and warningsaserrors

    @benvillalobos
    benvillalobos committed Feb 20, 2021
    Copy the full SHA
    cdb831e View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. Add test that shows even if a task logs an error but returns true the… 

    … build will continue. Add custom task that returns and logs what you want.
    @benvillalobos
    benvillalobos committed Feb 23, 2021
    Copy the full SHA
    6cd3074 View commit details
    Browse the repository at this point in the history

  2. BuildEngine may not be an IBE8

    @benvillalobos
    benvillalobos committed Feb 23, 2021
    Copy the full SHA
    53c5b0e View commit details
    Browse the repository at this point in the history

  3. Exclude warnings->messages from warnings->errors because the former t… 

    …akes priority. Cache the hashset in TaskHost
    @benvillalobos
    benvillalobos committed Feb 23, 2021
    Copy the full SHA
    4af8ce6 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Consider when WarningsAsErrors is an empty set that means we treat AL… 

    …L warnings as errors.

Add tests verifying various builds and results for warnings as errors
    @benvillalobos
    benvillalobos committed Feb 24, 2021
    Copy the full SHA
    b396ed5 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. Properly remove all warningsasmessages from warningsaserrors. handle … 

    …case where an empty set means all warnings are errors. Rename function for clarity
    @benvillalobos
    benvillalobos committed Feb 25, 2021
    Copy the full SHA
    764df59 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. Add customization to what CustomLogAndReturn task returns

    @benvillalobos
    benvillalobos committed Mar 1, 2021
    Copy the full SHA
    fdd2419 View commit details
    Browse the repository at this point in the history

  2. Finalize tests. Remove test that _should not work but does_.

    @benvillalobos
    benvillalobos committed Mar 1, 2021
    Copy the full SHA
    5d7b16a View commit details
    Browse the repository at this point in the history

  3. Code review suggestion

    @benvillalobos
    benvillalobos committed Mar 1, 2021
    Copy the full SHA
    83f1b66 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. Minor code cleanup

    @benvillalobos
    benvillalobos committed Mar 2, 2021
    Copy the full SHA
    63be126 View commit details
    Browse the repository at this point in the history

  2. Explicitly call last overload of LogError

    @benvillalobos
    benvillalobos committed Mar 2, 2021
    Copy the full SHA
    28f55cb View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. Add null check for taskloggingcontext for test compatibility

    @benvillalobos
    benvillalobos committed Mar 3, 2021
    Copy the full SHA
    787982a View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. Add tests for task-batches

    @benvillalobos
    benvillalobos committed Mar 5, 2021
    Copy the full SHA
    d2c230c View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. Minor PR feedback

    @benvillalobos
    benvillalobos committed Mar 8, 2021
    Copy the full SHA
    7aa9763 View commit details
    Browse the repository at this point in the history

  2. Add arg names to taskhostconfig tests

    @benvillalobos
    benvillalobos committed Mar 8, 2021
    Copy the full SHA
    febb509 View commit details
    Browse the repository at this point in the history

  3. Reword 'thrown' to 'logged' to avoid confusion

    @benvillalobos
    benvillalobos committed Mar 8, 2021
    Copy the full SHA
    0ccb51c View commit details
    Browse the repository at this point in the history

  4. IBE8 now has ShouldTreatWarningAsError method

    @benvillalobos
    benvillalobos committed Mar 8, 2021
    Copy the full SHA
    7670dea View commit details
    Browse the repository at this point in the history

  5. WarningsAsErrors set turned into ICollection (taskhost side)

    @benvillalobos
    benvillalobos committed Mar 8, 2021
    Copy the full SHA
    9a485da View commit details
    Browse the repository at this point in the history

  6. Binary translator converts an ICollection of strings. OOPTHN now tran… 

    …slates ICollection
    @benvillalobos
    benvillalobos committed Mar 8, 2021
    Copy the full SHA
    924423b View commit details
    Browse the repository at this point in the history

  7. Rename arg to collection

    @benvillalobos
    benvillalobos committed Mar 8, 2021
    Copy the full SHA
    a969d83 View commit details
    Browse the repository at this point in the history

  8. Make ICollection translate method more generic

    @benvillalobos
    benvillalobos committed Mar 8, 2021
    Copy the full SHA
    b65e272 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. PR changes. Adding comments.

    @benvillalobos
    benvillalobos committed Mar 10, 2021
    Copy the full SHA
    9856364 View commit details
    Browse the repository at this point in the history