Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous refactors in Common props, targets and tasks #6161

Closed
wants to merge 3 commits into from
Closed

Miscellaneous refactors in Common props, targets and tasks #6161

wants to merge 3 commits into from

Commits on Nov 5, 2021

  1. Do use MSBuild's Path-specific property functions (Reverts #6245) 

    This reverts commit 0e4b0c2.
    @Nirmal4G
    Nirmal4G committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    3314811 View commit details
    Browse the repository at this point in the history

  2. Format Comments in Common props, targets and tasks 

    Make Common props, targets and tasks easier to read and understand.

Ensure they follow consistent formatting

E.g.: 2-space indent
```xml
  <!-- Single Line Comment Text -->
  <!--
    Multi Line Comment Text
    Another Comment Text
      Indented Comment Text
  -->
```
    @Nirmal4G
    Nirmal4G committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    2d97755 View commit details
    Browse the repository at this point in the history

  3. Miscellaneous refactors in Common props, targets and tasks 

    Make Common props, targets and tasks easier to read and understand.

in all files:
 - Fix improper leading and trailing spacing of strings within quotes.

in 'Microsoft.Common.props':
 - Move 'BaseIntermediateOutputPath' logic out of 'MSBuildProjectExtensionsPath' block.

in 'Microsoft.Common.CrossTargeting.targets':
 - Remove temporary import depending on 'CoreCrossTargetingTargetsPath' property.

in 'Microsoft.Common.CurrentVersion.targets':
 - Add single quotes to property names in text.
 - Set 'ProjectPath' to the now available 'MSBuildProjectDirectory'.
 - Simplified condition logic wherever based on 'OutputType' property.
 - Use 'ConfigurationName' property instead of 'Configuration' property.
    @Nirmal4G
    Nirmal4G committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    b66ebe1 View commit details
    Browse the repository at this point in the history