Use Span<T> on all platforms that support it #6130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgind
approved these changes
Feb 8, 2021
Forgind
added
the
merge-when-branch-open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
FEATURE_SPANis defined only when building the .NET Core flavor of MSBuild but the feature has been supported everywhere but downlevel .NET Framework for some time.Changes Made
Removed
FEATURE_SPANtogether with all code conditionally compiled when the flag was not defined. Wrapped the code in#if !CLR2COMPATIBILITYinstead as it's not used when building MSBuildTaskHost.Testing
Existing unit tests. There might be some very minor perf win on non-Windows OSes where we were previously using strings (i.e. Mono).
Notes
This is code cleanup.