Fix cache exception handling #6110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgind
approved these changes
Feb 3, 2021
|
|
||
| while (blockedNodes.Count > 0 || buildingNodes.Count > 0) | ||
| Dictionary<ProjectGraphNode, BuildResult> resultsPerNode; | ||
| using (cacheServiceTask.Result) |
There was a problem hiding this comment.
Can you explain why this changes the ordering versus when the graph build returns?
There was a problem hiding this comment.
using variables get disposed at the end of the block they're in. In this case the end of the block is after the last line in the block whish is the call to ReportResultsToSubmission, but the cache needs to be disposed (in order to surface any issues in EndBuildAsync) before the call to ReportResultsToSubmission.
cdmihai
force-pushed
the
fixCacheExceptionHandling
branch
3 times, most recently
from
7b9afd9
to
9e5cfc3
Compare
cdmihai
force-pushed
the
fixCacheExceptionHandling
branch
from
9e5cfc3
to
075a94c
Compare
cdmihai
force-pushed
the
fixCacheExceptionHandling
branch
from
075a94c
to
4583451
Compare
rokonec
added
the
merge-when-branch-open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues when the plugin throws an exception in Plugin.EndBuildAsync during graph builds: