Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize RAR's GetReferenceItems method #5929

Merged
merged 23 commits into from Feb 6, 2021
Merged

Optimize RAR's GetReferenceItems method #5929

merged 23 commits into from Feb 6, 2021

Commits on Dec 2, 2020

  1. Iterate over dictionary once

    @Forgind
    Forgind committed Dec 2, 2020
    Copy the full SHA
    cfe147c View commit details
    Browse the repository at this point in the history

  2. Avoid unnecessary initializations

    @Forgind
    Forgind committed Dec 2, 2020
    Copy the full SHA
    17015af View commit details
    Browse the repository at this point in the history

  3. Set copy local more efficiently 

    Changes "true" to "True" and "false" to "False", but that's ok because it should be case-insensitive.
    @Forgind
    Forgind committed Dec 2, 2020
    Copy the full SHA
    fec708e View commit details
    Browse the repository at this point in the history

  4. referenceItem should have no metadata initially

    @Forgind
    Forgind committed Dec 2, 2020
    Copy the full SHA
    ed2bc5c View commit details
    Browse the repository at this point in the history

  5. Update larger metadata dictionary

    @Forgind
    Forgind committed Dec 2, 2020
    Copy the full SHA
    2fc517f View commit details
    Browse the repository at this point in the history

  6. Set fusionName at end 

    This means we don't have to repeatedly unset it.
    @Forgind
    Forgind committed Dec 2, 2020
    Copy the full SHA
    1dc3bc5 View commit details
    Browse the repository at this point in the history

  7. Slightly simplify referenceItem creation

    @Forgind
    Forgind committed Dec 2, 2020
    Copy the full SHA
    77b1038 View commit details
    Browse the repository at this point in the history

  8. Fix typos

    @Forgind
    Forgind committed Dec 2, 2020
    Copy the full SHA
    507214d View commit details
    Browse the repository at this point in the history

  9. Addition to setting fusionName at end

    @Forgind
    Forgind committed Dec 2, 2020
    Copy the full SHA
    4945ad2 View commit details
    Browse the repository at this point in the history

  10. Shift other types of removed metadata later so they only have to be r… 

    …emoved once

nonForwardableMetadata?.Remove(ItemMetadataNames.*) is used to prevent the correct metadata value from being overwritten when metadata are re-added from nonForwardableMetadata.
    @Forgind
    Forgind committed Dec 2, 2020
    Copy the full SHA
    cf314ab View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2020

  1. Tests should permit case-insensitive metadata checks

    @Forgind
    Forgind committed Dec 3, 2020
    Copy the full SHA
    7077b0e View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2020

  1. Use ternary operators

    @Forgind
    Forgind committed Dec 4, 2020
    Copy the full SHA
    afe2cf0 View commit details
    Browse the repository at this point in the history

  2. Set items as a group 

    Also, comparing to a null value apparently always returns false, so the check I was using was bogus. This fixes that.
    @Forgind
    Forgind committed Dec 4, 2020
    Copy the full SHA
    9dccb26 View commit details
    Browse the repository at this point in the history

  3. PR comments

    @Forgind
    Forgind committed Dec 4, 2020
    Copy the full SHA
    147ef43 View commit details
    Browse the repository at this point in the history

  4. Revert "Tests should permit case-insensitive metadata checks" 

    This reverts commit 7077b0e.
    @Forgind
    Forgind committed Dec 4, 2020
    Copy the full SHA
    2901929 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2020

  1. PR comments

    @Forgind
    Forgind committed Dec 6, 2020
    Copy the full SHA
    fd0a93d View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2020

  1. PR feedback

    @Forgind
    Forgind committed Dec 7, 2020
    Copy the full SHA
    74cf67c View commit details
    Browse the repository at this point in the history

  2. Update src/MSBuildTaskHost/Immutable/ImmutableDictionary.cs 

    Co-authored-by: Rainer Sigwald <raines@microsoft.com>
    @Forgind @rainersigwald
    Forgind and rainersigwald committed Dec 7, 2020
    Copy the full SHA
    8a45a46 View commit details
    Browse the repository at this point in the history

  3. Correct setting items

    @Forgind
    Forgind committed Dec 7, 2020
    Copy the full SHA
    2a8893c View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. Make align with old way

    @Forgind
    Forgind committed Jan 26, 2021
    Copy the full SHA
    04e72ed View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2021

  1. Use _metadata directly

    @Forgind
    Forgind committed Feb 1, 2021
    Copy the full SHA
    2bb3210 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2021

  1. Merge https://github.com/dotnet/msbuild into optimize-rar

    @Forgind
    Forgind committed Feb 2, 2021
    Copy the full SHA
    ff501aa View commit details
    Browse the repository at this point in the history

  2. Access remote metadata indirectly 

    A TaskItem in AppDomain A is identical to a TaskItem in AppDomain B, but the TaskItems cannot access each other's fields, only their properties. This changes accessing a possibly remote TaskItem's _metadata field into accessing its Metadata property.
    @Forgind
    Forgind committed Feb 2, 2021
    Copy the full SHA
    2f23808 View commit details
    Browse the repository at this point in the history