Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce cross-process resource management for tasks #5859

Merged
merged 118 commits into from Mar 30, 2021
Merged

Introduce cross-process resource management for tasks #5859

merged 118 commits into from Mar 30, 2021

Commits on Feb 25, 2020

  1. Initial draft of changes.

    @benvillalobos
    benvillalobos committed Feb 25, 2020
    Copy the full SHA
    f48f3d9 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2020

  1. Modified mockengine to support ibuildengine7 

    Got straightforward unit tests working.
Added null check and cached the Semaphore.
    @benvillalobos
    benvillalobos committed Feb 26, 2020
    Copy the full SHA
    bcccfea View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2020

  1. Simpler null checks

    @benvillalobos
    benvillalobos committed Feb 28, 2020
    Copy the full SHA
    73b3466 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. Merge remote-tracking branch 'upstream/master' into 74-cpp-parallel

    @rainersigwald
    rainersigwald committed Mar 4, 2020
    Copy the full SHA
    a8df6ac View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2020

  1. Clean up API surface

    @rainersigwald
    rainersigwald committed Apr 27, 2020
    Copy the full SHA
    963a785 View commit details
    Browse the repository at this point in the history

  2. Tasks type name

    @rainersigwald
    rainersigwald committed Apr 27, 2020
    Copy the full SHA
    e1a30e6 View commit details
    Browse the repository at this point in the history

  3. simple project

    @rainersigwald
    rainersigwald committed Apr 27, 2020
    Copy the full SHA
    055116a View commit details
    Browse the repository at this point in the history

  4. Simplify if-appdomain in NodeConfiguration

    @rainersigwald
    rainersigwald committed Apr 27, 2020
    Copy the full SHA
    10f6eed View commit details
    Browse the repository at this point in the history

  5. Checkpoint

    @rainersigwald
    rainersigwald committed Apr 27, 2020
    Copy the full SHA
    aa3f385 View commit details
    Browse the repository at this point in the history

  6. Remove FEATURE_VARIOUS_EXCEPTIONS

    @rainersigwald
    rainersigwald committed Apr 27, 2020
    Copy the full SHA
    57a5c93 View commit details
    Browse the repository at this point in the history

  7. Checkpoint: works on full only, doesn't properly block when all resou… 

    …rces consumed but want to start a task
    @rainersigwald
    rainersigwald committed Apr 27, 2020
    Copy the full SHA
    9229122 View commit details
    Browse the repository at this point in the history

  8. Make TaskHost.MarkAsInactive work on Core

    @rainersigwald
    rainersigwald committed Apr 27, 2020
    Copy the full SHA
    b919834 View commit details
    Browse the repository at this point in the history

  9. Tweak test to show cross-process handling

    @rainersigwald
    rainersigwald committed Apr 27, 2020
    Copy the full SHA
    01953aa View commit details
    Browse the repository at this point in the history

  10. Introduce RequireCores

    @rainersigwald
    rainersigwald committed Apr 27, 2020
    Copy the full SHA
    1183e87 View commit details
    Browse the repository at this point in the history

  11. WIP

    @rainersigwald
    rainersigwald committed Apr 27, 2020
    Copy the full SHA
    0437c32 View commit details
    Browse the repository at this point in the history

  12. Revert "WIP" 

    This reverts commit f60c66a.
    @rainersigwald
    rainersigwald committed Apr 27, 2020
    Copy the full SHA
    1bf3017 View commit details
    Browse the repository at this point in the history

  13. Horrible pile of WIP hacks to debug hang

    @rainersigwald
    rainersigwald committed Apr 27, 2020
    Copy the full SHA
    1ada7c2 View commit details
    Browse the repository at this point in the history

  14. Revert "Horrible pile of WIP hacks to debug hang" 

    This reverts commit 3c7a3f8.
    @rainersigwald
    rainersigwald committed Apr 27, 2020
    Copy the full SHA
    e943655 View commit details
    Browse the repository at this point in the history

  15. Move requiring core to ExecuteInstantiatedTask 

    This should alleviate hangs that were happening as a result of leaks
that happened when MSBuild/CallTarget got a resource, then
we started building other projects.
    @rainersigwald
    rainersigwald committed Apr 27, 2020
    Copy the full SHA
    ca6697d View commit details
    Browse the repository at this point in the history

  16. Merge remote-tracking branch 'upstream/master' into exp/resource-mana… 

    …gement
    @rainersigwald
    rainersigwald committed Apr 27, 2020
    Copy the full SHA
    63a324b View commit details
    Browse the repository at this point in the history

Commits on May 1, 2020

  1. Release core when yielding (hopefully working around hang when many t… 

    …hreads yielded + reacquiring)
    @rainersigwald
    rainersigwald committed May 1, 2020
    Copy the full SHA
    09618ec View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2020

  1. WIP: new semaphore name per session (by default)

    @rainersigwald
    rainersigwald committed Jun 10, 2020
    Copy the full SHA
    5a7ad2b View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2020

  1. Merge remote-tracking branch 'upstream/master' into exp/resource-mana… 

    …gement
    @rainersigwald
    rainersigwald committed Jun 11, 2020
    Copy the full SHA
    141c57c View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. Release a core when calling BuildProjectFiles 

    Otherwise, we can deadlock: outer task gets a resource, (logically) yields to build other projects; they block on getting a resource.
    @rainersigwald
    rainersigwald committed Jun 16, 2020
    Copy the full SHA
    007d9f3 View commit details
    Browse the repository at this point in the history

  2. Switch expression for MockHost.GetComponent

    @rainersigwald
    rainersigwald committed Jun 16, 2020
    Copy the full SHA
    6b2be21 View commit details
    Browse the repository at this point in the history

  3. Resource manager in MockHost

    @rainersigwald
    rainersigwald committed Jun 16, 2020
    Copy the full SHA
    5d49876 View commit details
    Browse the repository at this point in the history

  4. Just don't do resource management on non-Windows

    @rainersigwald
    rainersigwald committed Jun 16, 2020
    Copy the full SHA
    0486730 View commit details
    Browse the repository at this point in the history

  5. Delete bogus tests

    @rainersigwald
    rainersigwald committed Jun 16, 2020
    Copy the full SHA
    2f85924 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. Doc for RequestCores

    @rainersigwald
    rainersigwald committed Jun 17, 2020
    Copy the full SHA
    5e4b035 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into exp/resource-mana… 

    …gement
    @rainersigwald
    rainersigwald committed Jun 17, 2020
    Copy the full SHA
    a9d37a2 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2020

  1. Merge remote-tracking branch 'upstream/master' into exp/resource-mana… 

    …gement
    @rainersigwald
    rainersigwald committed Jul 15, 2020
    Copy the full SHA
    43bdec0 View commit details
    Browse the repository at this point in the history

  2. Add BlockingWaitForCore

    @rainersigwald
    rainersigwald committed Jul 15, 2020
    Copy the full SHA
    479cdfc View commit details
    Browse the repository at this point in the history

  3. Treat resources as a separate pool; don't auto-acquire for tasks

    @rainersigwald
    rainersigwald committed Jul 15, 2020
    Copy the full SHA
    9db29bb View commit details
    Browse the repository at this point in the history

  4. fixup! Add BlockingWaitForCore

    @rainersigwald
    rainersigwald committed Jul 15, 2020
    Copy the full SHA
    e1c3bff View commit details
    Browse the repository at this point in the history

  5. Doc updates

    @rainersigwald
    rainersigwald committed Jul 15, 2020
    Copy the full SHA
    58fa355 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2020

  1. Merge remote-tracking branch 'upstream/master' into exp/resource-mana… 

    …gement
    @rainersigwald
    rainersigwald committed Sep 16, 2020
    Copy the full SHA
    a6a9d6d View commit details
    Browse the repository at this point in the history

  2. Block for at least one core in RequestCores

    @rainersigwald
    rainersigwald committed Sep 16, 2020
    Copy the full SHA
    91fe07a View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2020

  1. Merge remote-tracking branch 'upstream/master' into exp/resource-mana… 

    …gement
    @rainersigwald
    rainersigwald committed Oct 21, 2020
    Copy the full SHA
    c9b3c78 View commit details
    Browse the repository at this point in the history

  2. Remove BlockingWaitForCore() since it's now redundant

    @rainersigwald
    rainersigwald committed Oct 21, 2020
    Copy the full SHA
    ba2db9a View commit details
    Browse the repository at this point in the history

  3. fixup! Block for at least one core in RequestCores

    @rainersigwald
    rainersigwald committed Oct 21, 2020
    Copy the full SHA
    cc60df9 View commit details
    Browse the repository at this point in the history

  4. Move to IBuildEngine8 since 7 shipped already

    @rainersigwald
    rainersigwald committed Oct 21, 2020
    Copy the full SHA
    0ab0481 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2020

  1. remove test-project.proj

    @rainersigwald
    rainersigwald committed Nov 3, 2020
    Copy the full SHA
    f1e26c3 View commit details
    Browse the repository at this point in the history

  2. Remove SemaphoreCPUTask

    @rainersigwald
    rainersigwald committed Nov 3, 2020
    Copy the full SHA
    dfced2f View commit details
    Browse the repository at this point in the history

  3. ??

    @rainersigwald
    rainersigwald committed Nov 3, 2020
    Copy the full SHA
    ed6a404 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2020

  1. sort usings in MockHost

    @rainersigwald
    rainersigwald committed Nov 5, 2020
    Copy the full SHA
    4545858 View commit details
    Browse the repository at this point in the history

  2. fixup! Treat resources as a separate pool; don't auto-acquire for tasks

    @rainersigwald
    rainersigwald committed Nov 5, 2020
    Copy the full SHA
    3de11c0 View commit details
    Browse the repository at this point in the history

  3. fixup! Remove BlockingWaitForCore() since it's now redundant

    @rainersigwald
    rainersigwald committed Nov 5, 2020
    Copy the full SHA
    608bed7 View commit details
    Browse the repository at this point in the history

  4. fixup! Treat resources as a separate pool; don't auto-acquire for tasks

    @rainersigwald
    rainersigwald committed Nov 5, 2020
    Copy the full SHA
    7a3da6b View commit details
    Browse the repository at this point in the history

  5. Remove RequireCores

    @rainersigwald
    rainersigwald committed Nov 5, 2020
    Copy the full SHA
    d87903f View commit details
    Browse the repository at this point in the history

  6. Better non-Windows behavior 

    Assert TODOs were invalid because it's no longer a simple check
    @rainersigwald
    rainersigwald committed Nov 5, 2020
    Copy the full SHA
    9a83f35 View commit details
    Browse the repository at this point in the history

  7. fixup! Move to IBuildEngine8 since 7 shipped already

    @rainersigwald
    rainersigwald committed Nov 5, 2020
    Copy the full SHA
    77344e2 View commit details
    Browse the repository at this point in the history

  8. Generalize MockEngine semaphore

    @rainersigwald
    rainersigwald committed Nov 5, 2020
    Copy the full SHA
    7fffd46 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2020

  1. Return nullable int to indicate whether resource management is possible

    @rainersigwald
    rainersigwald committed Dec 7, 2020
    Copy the full SHA
    7d8b359 View commit details
    Browse the repository at this point in the history

  2. fixup! Remove RequireCores

    @rainersigwald
    rainersigwald committed Dec 7, 2020
    Copy the full SHA
    82a25c4 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2020

  1. Merge remote-tracking branch 'upstream/master' into HEAD

    @rainersigwald
    rainersigwald committed Dec 8, 2020
    Copy the full SHA
    c6d1a8a View commit details
    Browse the repository at this point in the history

  2. Nix whitespace-only changes in ProjectCollection

    @rainersigwald
    rainersigwald committed Dec 8, 2020
    Copy the full SHA
    b8b52cc View commit details
    Browse the repository at this point in the history

  3. fixup! fixup! Remove BlockingWaitForCore() since it's now redundant

    @rainersigwald
    rainersigwald committed Dec 8, 2020
    Copy the full SHA
    f3e347e View commit details
    Browse the repository at this point in the history

  4. Task whitespace fixes

    @rainersigwald
    rainersigwald committed Dec 8, 2020
    Copy the full SHA
    ab384aa View commit details
    Browse the repository at this point in the history

  5. Update doc for non-Windows behavior

    @rainersigwald
    rainersigwald committed Dec 8, 2020
    Copy the full SHA
    a9d8061 View commit details
    Browse the repository at this point in the history

  6. Update doc with better example, caveats

    @rainersigwald
    rainersigwald committed Dec 8, 2020
    Copy the full SHA
    25ec10c View commit details
    Browse the repository at this point in the history

  7. Whitespace fixes in TaskBuilder

    @rainersigwald
    rainersigwald committed Dec 8, 2020
    Copy the full SHA
    b362600 View commit details
    Browse the repository at this point in the history

  8. Whitespace cleanup in TaskHost

    @rainersigwald
    rainersigwald committed Dec 8, 2020
    Copy the full SHA
    b830c49 View commit details
    Browse the repository at this point in the history

  9. Clarity in MockHost

    @rainersigwald
    rainersigwald committed Dec 8, 2020
    Copy the full SHA
    bb2d947 View commit details
    Browse the repository at this point in the history

  10. fixup! fixup! fixup! Remove BlockingWaitForCore() since it's now redu… 

    …ndant
    @rainersigwald
    rainersigwald committed Dec 8, 2020
    Copy the full SHA
    59af842 View commit details
    Browse the repository at this point in the history

  11. Log resource requests/releases 

    This may be a perf hog; we should consider demoting these messages to
ETW events. But for v1 they might be very valuable, so log.
    @rainersigwald
    rainersigwald committed Dec 8, 2020
    Copy the full SHA
    cacc2ac View commit details
    Browse the repository at this point in the history

  12. Move clamp on release to service layer

    @rainersigwald
    rainersigwald committed Dec 8, 2020
    Copy the full SHA
    3c0a8e7 View commit details
    Browse the repository at this point in the history

  13. Switch system off more gracefully on non-Windows

    @rainersigwald
    rainersigwald committed Dec 8, 2020
    Copy the full SHA
    ded86d5 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2020

  1. Merge remote-tracking branch 'upstream/master' into exp/resource-mana… 

    …gement
    @rainersigwald
    rainersigwald committed Dec 14, 2020
    Copy the full SHA
    ad77314 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2020

  1. Release nodes on reacquire

    @rainersigwald
    rainersigwald committed Dec 15, 2020
    Copy the full SHA
    0c0c0b4 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into exp/resource-mana… 

    …gement
    @rainersigwald
    rainersigwald committed Dec 15, 2020
    Copy the full SHA
    a16ca54 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into exp/resource-mana… 

    …gement
    @rainersigwald
    rainersigwald committed Dec 15, 2020
    Copy the full SHA
    1a497d7 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Implicit core for nonblocking 1 return

    @rainersigwald
    rainersigwald committed Jan 5, 2021
    Copy the full SHA
    7a4e1e0 View commit details
    Browse the repository at this point in the history

  2. Allow environment variable MSBUILDRESOURCEMANAGEROVERSUBSCRIPTION to … 

    …control oversubscription
    @rainersigwald
    rainersigwald committed Jan 5, 2021
    Copy the full SHA
    3d2575c View commit details
    Browse the repository at this point in the history

  3. Revert "Release nodes on reacquire" 

    This reverts commit 0c0c0b4.
    @rainersigwald
    rainersigwald committed Jan 5, 2021
    Copy the full SHA
    c416bf5 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. WIP: acquire/release resources in the scheduler

    @rainersigwald
    rainersigwald committed Jan 15, 2021
    Copy the full SHA
    444ffde View commit details
    Browse the repository at this point in the history

  2. Update documentation/specs/resource-management.md 

    Co-authored-by: Rainer Sigwald <raines@microsoft.com>
    @cdmihai @rainersigwald
    cdmihai and rainersigwald committed Jan 15, 2021
    Copy the full SHA
    761fb6a View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. Merge remote-tracking branch 'dotnet/master' into exp/resource-manage… 

    …ment
    @ladipro
    ladipro committed Feb 17, 2021
    Copy the full SHA
    2fb5789 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. Remove Semaphore-based logic

    @ladipro
    ladipro committed Feb 22, 2021
    Copy the full SHA
    2ce2af8 View commit details
    Browse the repository at this point in the history

  2. Plumbing to pass ResourceRequest to scheduler and ResourceResponse ba… 

    …ck to task
    @ladipro
    ladipro committed Feb 22, 2021
    Copy the full SHA
    e3439e4 View commit details
    Browse the repository at this point in the history

  3. Add missing files: ResourceRequest.cs, ResourceResponse.cs

    @ladipro
    ladipro committed Feb 22, 2021
    Copy the full SHA
    1653806 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Plumbing fixes

    @ladipro
    ladipro committed Feb 24, 2021
    Copy the full SHA
    6d27a28 View commit details
    Browse the repository at this point in the history

  2. Implement scheduling policy

    @ladipro
    ladipro committed Feb 24, 2021
    Copy the full SHA
    df40170 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. Use 'implicit core' always, not only when scheduler returns 0

    @ladipro
    ladipro committed Mar 1, 2021
    Copy the full SHA
    3d03f86 View commit details
    Browse the repository at this point in the history

  2. Use different limits for scheduling and explicit core requests

    @ladipro
    ladipro committed Mar 1, 2021
    Copy the full SHA
    ba264da View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. Make RequestCores ignore the executing request count

    @ladipro
    ladipro committed Mar 5, 2021
    Copy the full SHA
    d12bd75 View commit details
    Browse the repository at this point in the history

  2. Subtract one from _coreLimit

    @ladipro
    ladipro committed Mar 5, 2021
    Copy the full SHA
    1a6326e View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. Change return value of RequestCores to int (null is no longer used)

    @ladipro
    ladipro committed Mar 12, 2021
    Copy the full SHA
    0b1a487 View commit details
    Browse the repository at this point in the history

  2. Do not assume that RequestCores calls come only from Executing requests

    @ladipro
    ladipro committed Mar 12, 2021
    Copy the full SHA
    d38500b View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Make RequestCores block and wait for at least one core

    @ladipro
    ladipro committed Mar 16, 2021
    Copy the full SHA
    445ec33 View commit details
    Browse the repository at this point in the history

  2. Revert "Use 'implicit core' always, not only when scheduler returns 0" 

    This reverts commit 3d03f86.
    @ladipro
    ladipro committed Mar 16, 2021
    Copy the full SHA
    a98adee View commit details
    Browse the repository at this point in the history

  3. Make the first RequestCores call non-blocking (via 'implicit' core)

    @ladipro
    ladipro committed Mar 16, 2021
    Copy the full SHA
    15121be View commit details
    Browse the repository at this point in the history

  4. Make the implicit core the last one to release (LIFO)

    @ladipro
    ladipro committed Mar 16, 2021
    Copy the full SHA
    02bce34 View commit details
    Browse the repository at this point in the history

  5. Introduce MSBUILDNODECOREALLOCATIONWEIGHT

    @ladipro
    ladipro committed Mar 16, 2021
    Copy the full SHA
    b382aab View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2021

  1. Merge remote-tracking branch 'dotnet/main' into exp/resource-management

    @ladipro
    ladipro committed Mar 19, 2021
    Copy the full SHA
    8dbe055 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. Allow calling RequestCores/ReleaseCores after Yield

    @ladipro
    ladipro committed Mar 23, 2021
    Copy the full SHA
    14c5d3d View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. Update resource-management.md

    @ladipro
    ladipro committed Mar 24, 2021
    Copy the full SHA
    aad6f76 View commit details
    Browse the repository at this point in the history

  2. Comments, renames, and tweaks

    @ladipro
    ladipro committed Mar 24, 2021
    Copy the full SHA
    3a554b8 View commit details
    Browse the repository at this point in the history

  3. Remove the now unused ResourceManagerService

    @ladipro
    ladipro committed Mar 24, 2021
    Copy the full SHA
    63d782e View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2021

  1. Comments, renames, and tweaks

    @ladipro
    ladipro committed Mar 25, 2021
    Copy the full SHA
    874ecf3 View commit details
    Browse the repository at this point in the history

  2. Comments, renames, and tweaks

    @ladipro
    ladipro committed Mar 25, 2021
    Copy the full SHA
    8ed06ad View commit details
    Browse the repository at this point in the history

  3. Revert string changes

    @ladipro
    ladipro committed Mar 25, 2021
    Copy the full SHA
    97e9f5d View commit details
    Browse the repository at this point in the history

  4. Tweaks in Scheduler.cs

    @ladipro
    ladipro committed Mar 25, 2021
    Copy the full SHA
    531ee86 View commit details
    Browse the repository at this point in the history

  5. Refactor SchedulingData & SchedulableRequest, don't consider nodes wi… 

    …th Yielded tasks busy
    @ladipro
    ladipro committed Mar 25, 2021
    Copy the full SHA
    27865a8 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2021

  1. Don't wait for ResourceResponse under a lock

    @ladipro
    ladipro committed Mar 26, 2021
    Copy the full SHA
    8016cf9 View commit details
    Browse the repository at this point in the history

  2. Release all cores on reacquire

    @ladipro
    ladipro committed Mar 26, 2021
    Copy the full SHA
    d10923f View commit details
    Browse the repository at this point in the history

  3. Renames and tweaks

    @ladipro
    ladipro committed Mar 26, 2021
    Copy the full SHA
    3ac6642 View commit details
    Browse the repository at this point in the history

  4. Add unit tests to TaskHost_Tests

    @ladipro
    ladipro committed Mar 26, 2021
    Copy the full SHA
    059ac7b View commit details
    Browse the repository at this point in the history

  5. Fix bug in scheduler where cores were not granted during build rundown

    @ladipro
    ladipro committed Mar 26, 2021
    Copy the full SHA
    1340f7c View commit details
    Browse the repository at this point in the history

  6. Rework RequestCores concurrency

    @ladipro
    ladipro committed Mar 26, 2021
    Copy the full SHA
    f2381ad View commit details
    Browse the repository at this point in the history

  7. Fix ArgumentOutOfRangeException in ReleaseAllCores

    @ladipro
    ladipro committed Mar 26, 2021
    Copy the full SHA
    605f6f2 View commit details
    Browse the repository at this point in the history

  8. Add ResourceManagement_Tests

    @ladipro
    ladipro committed Mar 26, 2021
    Copy the full SHA
    876fef6 View commit details
    Browse the repository at this point in the history

  9. Move state check and make tests Core-compatible

    @ladipro
    ladipro committed Mar 26, 2021
    Copy the full SHA
    f9f0185 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. PR feedback: Make instantiation of ResourceRequest more readable

    @ladipro
    ladipro committed Mar 29, 2021
    Copy the full SHA
    719425b View commit details
    Browse the repository at this point in the history

  2. PR feedback: Move the new API to IBuildEngine9

    @ladipro
    ladipro committed Mar 29, 2021
    Copy the full SHA
    2a6cabe View commit details
    Browse the repository at this point in the history

  3. PR feedback: Add comments to RequestBuilder.RequestCores

    @ladipro
    ladipro committed Mar 29, 2021
    Copy the full SHA
    8b53959 View commit details
    Browse the repository at this point in the history

  4. PR feedback: Document callers of IRequestBuilderCallback.RequestCores… 

    …/ReleaseCores
    @ladipro
    ladipro committed Mar 29, 2021
    Copy the full SHA
    74046a0 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. PR feedback: Comment new environment variables

    @ladipro
    ladipro committed Mar 30, 2021
    Copy the full SHA
    93db0c1 View commit details
    Browse the repository at this point in the history

  2. PR feedback: Add RequestCores/ReleaseCores logging

    @ladipro
    ladipro committed Mar 30, 2021
    Copy the full SHA
    de74af6 View commit details
    Browse the repository at this point in the history