Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BuildCheck docs with enablement design #10033

Merged
merged 4 commits into from May 9, 2024

Conversation

ladipro
Copy link
Member

@ladipro ladipro commented Apr 18, 2024

Fixes #9822
Fixes #9723

Context

Some of the built-in BuildCheck analyzers will eventually be enabled by default. We need to figure out the mechanics of how it's going to happen.

Changes Made

Updated parts of the BuildCheck spec documents.

Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the proposal!

I'm bit worried about flipping from switch to a property and hence possibility of that warying throughout the build.

Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is putting together lot of importnat thoughts - Thank you!!

@YuliiaKovalova YuliiaKovalova self-requested a review May 6, 2024 12:46
documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved
@ladipro ladipro enabled auto-merge (squash) May 9, 2024 21:02
@ladipro ladipro merged commit a8e224f into dotnet:main May 9, 2024
10 checks passed
@ladipro ladipro deleted the analyzer-enablement branch May 10, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants