Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Arm64 VS not localization #10023

Merged
merged 3 commits into from Apr 28, 2024
Merged

Fix Arm64 VS not localization #10023

merged 3 commits into from Apr 28, 2024

Conversation

JaynieBai
Copy link
Member

@JaynieBai JaynieBai commented Apr 17, 2024

Fixes #1806513

Context

On the arm64, the build output is not localized as amd64 results.
amd64
image
arm64
image

Changes Made

copy all of our loc .resources assemblies to the arm64 .swr file. Same with amd64

Testing

Download the experimental VS insertion https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9429933&view=ms.vss-build-web.run-extensions-tab to install the VS. Set the language as Chinese and find translated.

image

Notes

@JaynieBai JaynieBai marked this pull request as ready for review April 17, 2024 09:00
@JaynieBai JaynieBai merged commit 9d01a8d into main Apr 28, 2024
9 checks passed
@JaynieBai JaynieBai deleted the exp/arm64localization branch April 28, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants