Just call Arrange to set the Frame #8569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartez
reviewed
Jul 6, 2022
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/UIContainerView.cs
Outdated
Show resolved
Hide resolved
PureWeen
force-pushed
the
fix_shell_flyout_header_ios
branch
from
4122108
to
03993fc
Compare
PureWeen
changed the title
jsuarezruiz
added
area/shell 🐢
jsuarezruiz
reviewed
Jul 7, 2022
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellFlyoutLayoutManager.cs
Outdated
Show resolved
Hide resolved
hartez
approved these changes
Jul 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The following PR added a
SetNeedsLayoutcall that will propagate up to the FlyoutHeader container during LayoutSubviews. This causes an infinite loop so this stops the call toSetNeedsLayoutif the call comes fromLayoutSubviewsI doubt this is the best fix but it's the fix that gets it back to not crashing. The best fix will come once this issue is fixed #8568
Issues Fixed
Fixes #8146
Testing info
We have tests for this but we're still figuring out why shell tests don't run on CI .